From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9BB556F3A6 for ; Thu, 10 Jan 2019 15:59:27 +0000 (UTC) From: Jani Nikula In-Reply-To: <20190110153622.23897-1-chris@chris-wilson.co.uk> References: <20190110153622.23897-1-chris@chris-wilson.co.uk> Date: Thu, 10 Jan 2019 18:01:07 +0200 Message-ID: <87va2w5wos.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] lib/sysfs: Repair override of params = -1 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Chris Wilson , igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCAxMCBKYW4gMjAxOSwgQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28u dWs+IHdyb3RlOgo+IENvbW1pdCBlMjc2MjY4OThiODcgKCJpZ3Q6IENoZWNrIHRoZSBwaHlzaWNh bCBzd2l6emxlIHN0YXR1cyIpIHN0b3BwZWQKPiB0cnlpbmcgdG8gY2hhc2UgdGhlIHBhcmFtZXRl cnMgZnJvbSB0aGUgZGV2aWNlIHN5c2ZzLCBlbnRpcmVseSBieQo+IGFjY2lkZW50LiBNYWtlIGl0 IGEgdGlueSBiaXQgbW9yZSByb2J1c3QgYnkgZm9yZ2l2aW5nIHRoZSBzeXNmcyBkZXZpY2UKPiBu b3QgYmVpbmcgcHJlc2VudCBhbmQganVtcGluZyB0byB0aGUgL3N5cy9tb2R1bGUgKyBkcml2ZXIg bmFtZSBwYXJhbQo+IGxvb2t1cCBmYWxsYmFjay4KPgo+IFJlcG9ydGVkLWJ5OiBKYW5pIE5pa3Vs YSA8amFuaS5uaWt1bGFAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8 Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFA aW50ZWwuY29tPgoKVGhhbmtzLAoKUmV2aWV3ZWQtYnk6IEphbmkgTmlrdWxhIDxqYW5pLm5pa3Vs YUBpbnRlbC5jb20+CgoKPiAtLS0KPiAgbGliL2lndF9zeXNmcy5jIHwgMTYgKysrKysrKystLS0t LS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQo+ Cj4gZGlmZiAtLWdpdCBhL2xpYi9pZ3Rfc3lzZnMuYyBiL2xpYi9pZ3Rfc3lzZnMuYwo+IGluZGV4 IGQzMjNiODFkZC4uY2NlMzQyYTA1IDEwMDY0NAo+IC0tLSBhL2xpYi9pZ3Rfc3lzZnMuYwo+ICsr KyBiL2xpYi9pZ3Rfc3lzZnMuYwo+IEBAIC0xODksNyArMTg5LDcgQEAgYm9vbCBpZ3Rfc3lzZnNf c2V0X3BhcmFtZXRlcihpbnQgZGV2aWNlLAo+ICAKPiAgLyoqCj4gICAqIGlndF9zeXNmc19vcGVu X3BhcmFtZXRlcnM6Cj4gLSAqIEBkZXZpY2U6IGZkIG9mIHRoZSBkZXZpY2UgKG9yIC0xIHRvIGRl ZmF1bHQgdG8gSW50ZWwpCj4gKyAqIEBkZXZpY2U6IGZkIG9mIHRoZSBkZXZpY2UKPiAgICoKPiAg ICogVGhpcyBvcGVucyB0aGUgbW9kdWxlIHBhcmFtZXRlcnMgZGlyZWN0b3J5ICh1bmRlciBzeXNm cykgY29ycmVzcG9uZGluZwo+ICAgKiB0byB0aGUgZGV2aWNlIGZvciB1c2Ugd2l0aCBpZ3Rfc3lz ZnNfc2V0KCkgYW5kIGlndF9zeXNmc19nZXQoKS4KPiBAQCAtMTk5LDE1ICsxOTksMTUgQEAgYm9v bCBpZ3Rfc3lzZnNfc2V0X3BhcmFtZXRlcihpbnQgZGV2aWNlLAo+ICAgKi8KPiAgaW50IGlndF9z eXNmc19vcGVuX3BhcmFtZXRlcnMoaW50IGRldmljZSkKPiAgewo+IC0JaW50IGRpciwgcGFyYW1z Owo+ICsJaW50IGRpciwgcGFyYW1zID0gLTE7Cj4gIAo+ICAJZGlyID0gaWd0X3N5c2ZzX29wZW4o ZGV2aWNlLCAmcGFyYW1zKTsKPiAtCWlmIChkaXIgPCAwKQo+IC0JCXJldHVybiAtMTsKPiAtCj4g LQlwYXJhbXMgPSAtMTsKPiAtCS8vcGFyYW1zID0gb3BlbmF0KGRpciwgImRldmljZS9kcml2ZXIv bW9kdWxlL3BhcmFtZXRlcnMiLCBPX1JET05MWSk7Cj4gLQljbG9zZShkaXIpOwo+ICsJaWYgKGRp ciA+PSAwKSB7Cj4gKwkJcGFyYW1zID0gb3BlbmF0KGRpciwKPiArCQkJCSJkZXZpY2UvZHJpdmVy L21vZHVsZS9wYXJhbWV0ZXJzIiwKPiArCQkJCU9fUkRPTkxZKTsKPiArCQljbG9zZShkaXIpOwo+ ICsJfQo+ICAKPiAgCWlmIChwYXJhbXMgPCAwKSB7IC8qIGJ1aWx0aW4/ICovCj4gIAkJZHJtX3Zl cnNpb25fdCB2ZXJzaW9uOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFw aGljcyBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==