From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D303C2BD09 for ; Mon, 1 Jul 2024 22:36:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C39BF10E02C; Mon, 1 Jul 2024 22:36:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="AvHn12r3"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8F43410E02C for ; Mon, 1 Jul 2024 22:36:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1719873386; x=1751409386; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=s43GbvujAGZ8uYmm2uXn9cS2Kwq7/xDaGF7JvjPy0ow=; b=AvHn12r32+N0hC5pLiOunzUY0rl6Mq8ZsOEBbGnvYjEdLs6X5T0K4GJh st28K90mlbthniS+jamigS5E3Vx9hMZ/HCaSouVjiBEPEZmHqA1hRP+Uy tGezpi1Hxi2gyHv3kI2wUG4hg46yVyb2nhBlcqQ9iW7y3mc2ceYok8Dfm H6+nw4NQreIJDOxG8trayWTgPWHc4iMio5YCvPtA1uR9et/1/Xxw/1Vt+ 1WeSXiNYsVbIk6MCBOz6IjM9lzPUpmwVQGpAOeJsEZy3xx8axrLfyROKv M6PArxkMYPCWcKLAJZdPi9QnP683ZlGScH258wlUhCAryy+fXpurVfytZ Q==; X-CSE-ConnectionGUID: If/14GWVR4urxcMqLNhu7A== X-CSE-MsgGUID: gxYK2D8lRse4ZFPYB4JUwQ== X-IronPort-AV: E=McAfee;i="6700,10204,11120"; a="42454055" X-IronPort-AV: E=Sophos;i="6.09,177,1716274800"; d="scan'208";a="42454055" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2024 15:36:25 -0700 X-CSE-ConnectionGUID: 7J9wT7InRlu0XE4u5irOzg== X-CSE-MsgGUID: TTMhZSYgQtqawa9d05Nb1A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.09,177,1716274800"; d="scan'208";a="50626631" Received: from smuley-mobl1.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.32.45]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jul 2024 15:36:23 -0700 Date: Mon, 01 Jul 2024 15:31:37 -0700 Message-ID: <87wmm4agmu.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: igt-dev@lists.freedesktop.org Subject: Re: [PATCH i-g-t 02/14] tests/intel/xe_oa: Add first tests In-Reply-To: References: <20240701025309.2416653-1-ashutosh.dixit@intel.com> <20240701025309.2416653-3-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.3 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 01 Jul 2024 12:47:45 -0700, Umesh Nerlige Ramappa wrote: > > > + [XE_OA_FORMAT_PEC36u64_G1_4_G2_32] = { > > + "PEC36u64_G1_4_G2_32_G2", .size = 320, > > + .oa_type = DRM_XE_OA_FMT_TYPE_PEC, > > + .report_hdr_64bit = true, > > + .counter_select = 4, > > + .counter_size = 1, > > + .bc_report = 0 }, > > +}; > > I think we should do away with the per platform arrays and instead do > something similar to what the KMD does - have a platform mask or something > because really the same format does not have a new definition for another > platform. It should just indicate what platforms the format is supported > on. Maybe please create an issue to track this and we can look at it later > sometime. Thanks Umesh, yup it's a good idea. I have created an issue about this. > > Reviewed-by: Umesh Nerlige Ramappa Thanks. -- Ashutosh