From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D56C810E0D4 for ; Thu, 31 Mar 2022 21:54:20 +0000 (UTC) Date: Thu, 31 Mar 2022 14:54:08 -0700 Message-ID: <87wng9hjpb.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Daniele Ceraolo Spurio In-Reply-To: <20220330183259.3003663-3-daniele.ceraolospurio@intel.com> References: <20220330183259.3003663-1-daniele.ceraolospurio@intel.com> <20220330183259.3003663-3-daniele.ceraolospurio@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t 2/2] lib/igt_kmod: Unload mei modules before unloading i915 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, Alexander Usyskin Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Wed, 30 Mar 2022 11:32:59 -0700, Daniele Ceraolo Spurio wrote: > > mei_gsc binds to an aux device exposed by i915, so it depends on it and > need to be removed before we can unload i915. > On platforms with a GSC, the mei components (pxp, hdcp) depend on > mei_gsc, so those need to be unloaded first. Reviewed-by: Ashutosh Dixit > Signed-off-by: Daniele Ceraolo Spurio > Cc: Alexander Usyskin > --- > lib/igt_kmod.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c > index d2ac8a56..28ffe515 100644 > --- a/lib/igt_kmod.c > +++ b/lib/igt_kmod.c > @@ -400,6 +400,10 @@ int __igt_i915_driver_unload(const char **who) > const char *aux[] = { > /* gen5: ips uses symbol_get() so only a soft module dependency */ > "intel_ips", > + /* mei_gsc uses an i915 aux dev and the other mei mods depend on it */ > + "mei_pxp", > + "mei_hdcp", > + "mei_gsc", > NULL, > }; > > -- > 2.25.1 >