From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 016456FE31 for ; Sat, 24 Jul 2021 21:20:22 +0000 (UTC) Date: Sat, 24 Jul 2021 14:20:19 -0700 Message-ID: <87wnpfo1d8.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20210724165317.32000-1-vidya.srinivas@intel.com> References: <20210724164624.31848-1-vidya.srinivas@intel.com> <20210724165317.32000-1-vidya.srinivas@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t] tests/kms: Return false in gem_has_lmem for kernels not having DRM_I915_QUERY_MEMORY_REGIONS support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Vidya Srinivas Cc: kunal1.joshi@intel.com, petri.latvala@intel.com, igt-dev@lists.freedesktop.org, juha-pekka.heikkila@intel.com, Lin Charlton List-ID: On Sat, 24 Jul 2021 09:53:17 -0700, Vidya Srinivas wrote: > > @@ -164,6 +175,9 @@ uint8_t gem_get_lmem_region_count(int fd) > */ > bool gem_has_lmem(int fd) > { > + int ret = gem_has_memregion_query_support(fd); > + if (ret == ENOSYS || ret == ENOTSUP) > + return false; > return gem_get_lmem_region_count(fd) > 0; gem_get_query_memory_regions is still broken. So we should use __i915_query_items there. The patch title also should not say tests/kms. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev