From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4CC4589811 for ; Tue, 10 Nov 2020 05:19:55 +0000 (UTC) Date: Mon, 09 Nov 2020 21:16:01 -0800 Message-ID: <87wnytg5bi.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20201110045510.14716-1-nidhi1.gupta@intel.com> References: <20201110045510.14716-1-nidhi1.gupta@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t] Fix IGT Warnings due to dynamic subtest inclusion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: petri.latvala@intel.com Cc: igt-dev@lists.freedesktop.org, nidhi1.gupta@intel.com List-ID: On Mon, 09 Nov 2020 20:55:10 -0800, wrote: > > From: Nidhi Gupta > > Signed-off-by: Nidhi Gupta > --- > tests/kms_atomic_interruptible.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/tests/kms_atomic_interruptible.c b/tests/kms_atomic_interruptible.c > index 27bb6a2b..f98023ca 100644 > --- a/tests/kms_atomic_interruptible.c > +++ b/tests/kms_atomic_interruptible.c > @@ -288,7 +288,9 @@ igt_main > for_each_pipe_with_valid_output(&display, pipe, output) { > igt_dynamic_f("%s-pipe-%s", igt_output_name(output), kmstest_pipe_name(pipe)) > run_plane_test(&display, pipe, output, test_legacy_modeset, DRM_PLANE_TYPE_PRIMARY); > + { > break; > + } > } Are we trying to break after the first call to run_plane_test() here? In that case why are we using a for loop (for_each_pipe_with_valid_output)? I am not sure if igt_subtest_with_dynamic/igt_dynamic_f combinations can take a break statement, this code pattern is certainly not used elsewhere. So the patch does fix the warnings (which is a relief) but otherwise I don't know if it makes sense. If not, I'd say revert the previous patch and do it a different way. _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev