From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, igt-dev@lists.freedesktop.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] i915/gem_ctx_persistence: Use "%u" for -1u conversion
Date: Tue, 26 May 2020 16:04:55 +0300 [thread overview]
Message-ID: <87wo4y26fc.fsf@intel.com> (raw)
In-Reply-To: <20200519063411.1541230-1-chris@chris-wilson.co.uk>
On Tue, 19 May 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> The debugfs modparams are more picky and refuse to do the implicit
> unsigned conversion.
I was wondering about this until I realized "reset" in i915_params.h has
type unsigned int, while the module param in i915_params.c has type
int. It's not that the debugfs is more picky, it's just that they have
different types!
BR,
Jani.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> ---
> tests/i915/gem_ctx_persistence.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c
> index ce9f02350..4a1ef0f27 100644
> --- a/tests/i915/gem_ctx_persistence.c
> +++ b/tests/i915/gem_ctx_persistence.c
> @@ -1127,7 +1127,7 @@ igt_main
> igt_require_gem(i915);
>
> /* Restore the reset modparam if left clobbered */
> - igt_assert(igt_params_set(i915, "reset", "%d", -1));
> + igt_assert(igt_params_set(i915, "reset", "%u", -1));
>
> enable_hangcheck(i915);
> igt_install_exit_handler(exit_handler);
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2020-05-26 13:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 6:34 [igt-dev] [PATCH i-g-t 1/3] i915/gem_ctx_persistence: Use "%u" for -1u conversion Chris Wilson
2020-05-19 6:34 ` [igt-dev] [PATCH i-g-t 2/3] Always pass device to igt_params_set Chris Wilson
2020-05-19 6:34 ` [igt-dev] [PATCH i-g-t 3/3] lib: Cleanup __igt_params_open() Chris Wilson
2020-05-19 7:17 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/3] i915/gem_ctx_persistence: Use "%u" for -1u conversion Patchwork
2020-05-19 8:44 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2020-05-20 9:34 ` [igt-dev] [PATCH i-g-t 1/3] " Juha-Pekka Heikkila
2020-05-26 13:04 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wo4y26fc.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox