From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AA006E10E for ; Wed, 5 Feb 2020 02:25:48 +0000 (UTC) Date: Tue, 04 Feb 2020 18:06:42 -0800 Message-ID: <87wo91lrd9.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" In-Reply-To: <20200131173109.12527-9-ramalingam.c@intel.com> References: <20200131173109.12527-1-ramalingam.c@intel.com> <20200131173109.12527-9-ramalingam.c@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Subject: Re: [igt-dev] [PATCH i-g-t 8/9] tests/i915_suspend: skip fence related tests, if no mmap_gtt List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Ramalingam C Cc: igt-dev List-ID: On Fri, 31 Jan 2020 09:31:08 -0800, Ramalingam C wrote: > > When mappable aperture is not available, skip the fencing related tests. > > Signed-off-by: Ramalingam C > --- > tests/i915/i915_suspend.c | 16 ++++++++++++---- > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/tests/i915/i915_suspend.c b/tests/i915/i915_suspend.c > index 5a2ec76699d6..47e134b12086 100644 > --- a/tests/i915/i915_suspend.c > +++ b/tests/i915/i915_suspend.c > @@ -208,11 +208,15 @@ igt_main > igt_fixture > fd = drm_open_driver(DRIVER_INTEL); > > - igt_subtest("fence-restore-tiled2untiled") > + igt_subtest("fence-restore-tiled2untiled") { > + gem_require_mappable_ggtt(fd); > test_fence_restore(fd, true, false); > + } > > - igt_subtest("fence-restore-untiled") > + igt_subtest("fence-restore-untiled") { > + gem_require_mappable_ggtt(fd); > test_fence_restore(fd, false, false); > + } > > igt_subtest("debugfs-reader") > test_debugfs_reader(fd, false); > @@ -226,11 +230,15 @@ igt_main > igt_subtest("forcewake") > test_forcewake(fd, false); > > - igt_subtest("fence-restore-tiled2untiled-hibernate") > + igt_subtest("fence-restore-tiled2untiled-hibernate") { > + gem_require_mappable_ggtt(fd); > test_fence_restore(fd, true, true); > + } > > - igt_subtest("fence-restore-untiled-hibernate") > + igt_subtest("fence-restore-untiled-hibernate") { > + gem_require_mappable_ggtt(fd); > test_fence_restore(fd, false, true); > + } Afaict test_fence_restore() is intimately related with gtt and tiling. So skipping makes sense: Reviewed-by: Ashutosh Dixit _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev