From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2FD856EE00 for ; Fri, 1 Feb 2019 09:37:15 +0000 (UTC) From: Jani Nikula In-Reply-To: <9cc49663-b6f7-48bb-9ced-dfaaf403d11e@linux.intel.com> References: <20190128115436.14527-1-maarten.lankhorst@linux.intel.com> <87zhrlynpo.fsf@intel.com> <9cc49663-b6f7-48bb-9ced-dfaaf403d11e@linux.intel.com> Date: Fri, 01 Feb 2019 11:38:47 +0200 Message-ID: <87womjyhjs.fsf@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t] debugfs: Fix writing an extra zero out of bounds in igt_crc_to_string_extended() List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Maarten Lankhorst , igt-dev@lists.freedesktop.org List-ID: T24gVGh1LCAzMSBKYW4gMjAxOSwgTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0 QGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cj4gT3AgMjgtMDEtMjAxOSBvbSAxMzoyNCBzY2hyZWVm IEphbmkgTmlrdWxhOgo+PiBPbiBNb24sIDI4IEphbiAyMDE5LCBNYWFydGVuIExhbmtob3JzdCA8 bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPiB3cm90ZToKPj4+IFNpZ25lZC1vZmYt Ynk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+ Cj4+PiAtLS0KPj4+ICBsaWIvaWd0X2RlYnVnZnMuYyB8IDggKysrKy0tLS0KPj4+ICAxIGZpbGUg Y2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+Pj4KPj4+IGRpZmYgLS1n aXQgYS9saWIvaWd0X2RlYnVnZnMuYyBiL2xpYi9pZ3RfZGVidWdmcy5jCj4+PiBpbmRleCAzNjU2 YzY2YTU2NzQuLmQxZmMwZmY3ZjcxMCAxMDA2NDQKPj4+IC0tLSBhL2xpYi9pZ3RfZGVidWdmcy5j Cj4+PiArKysgYi9saWIvaWd0X2RlYnVnZnMuYwo+Pj4gQEAgLTQ1OCwxNyArNDU4LDE3IEBAIGNo YXIgKmlndF9jcmNfdG9fc3RyaW5nX2V4dGVuZGVkKGlndF9jcmNfdCAqY3JjLCBjaGFyIGRlbGlt aXRlciwgaW50IGNyY19zaXplKQo+Pj4gIAlpbnQgaTsKPj4+ICAJaW50IGxlbiA9IDA7Cj4+PiAg CWludCBmaWVsZF93aWR0aCA9IDIgKiBjcmNfc2l6ZTsgLyogVHdvIGNoYXJzIHBlciBieXRlLiAq Lwo+Pj4gLQljaGFyICpidWYgPSBtYWxsb2MoKGZpZWxkX3dpZHRoKzEpICogY3JjLT5uX3dvcmRz ICogc2l6ZW9mKGNoYXIpKTsKPj4+ICsJY2hhciAqYnVmID0gbWFsbG9jKChmaWVsZF93aWR0aCsx KSAqIGNyYy0+bl93b3Jkcyk7Cj4+PiAgCj4+PiAgCWlmICghYnVmKQo+Pj4gIAkJcmV0dXJuIE5V TEw7Cj4+PiAgCj4+PiAtCWZvciAoaSA9IDA7IGkgPCBjcmMtPm5fd29yZHM7IGkrKykKPj4+ICsJ Zm9yIChpID0gMDsgaSA8IGNyYy0+bl93b3JkcyAtIDE7IGkrKykKPj4+ICAJCWxlbiArPSBzcHJp bnRmKGJ1ZiArIGxlbiwgIiUwKnglYyIsIGZpZWxkX3dpZHRoLAo+Pj4gIAkJCSAgICAgICBjcmMt PmNyY1tpXSwgZGVsaW1pdGVyKTsKPj4gT3Iga2VlcCB0aGUgbG9vcCBjb25kaXRpb24gYW5kIG1h a2UgdGhpczoKPj4KPj4gCQlsZW4gKz0gc3ByaW50ZihidWYgKyBsZW4sICIlcyUwKngiLCBpID8g JmRlbGltaXRlciA6ICIiLAo+PiAJCQkgICAgICAgZmllbGRfd2lkdGgsIGNyYy0+Y3JjW2ldKTsK Pj4KPj4gQWRkaXRpb25hbGx5IGNvdWxkIG1ha2UgdGhlIGRlbGltaXRlciBwYXNzZWQgaGVyZSBh IGNoYXIqLgo+Cj4gVGhhdCBpcyBhbHNvIGEgdmFsaWQgc29sdXRpb24uIDopIElzIGl0IG9rIHRv IGdvIHdpdGggdGhlIHNvbHV0aW9uIEkKPiBwcm9wb3NlZCBvciBkbyB5b3UgaGF2ZSBhIHN0cm9u ZyBwcmVmZXJlbmNlIGZvciB0aGF0Pwo+Cj4gSSBkb24ndCB0aGluayB3ZSBjYW4ganVzdCBwYXNz ICZkZWxpbWl0ZXIsIHdlIHdvdWxkIGRlcGVuZCBvbiB0aGUgbmV4dAo+IGJ5dGUgaW4gbWVtb3J5 IGFjY2lkZW50YWxseSBiZWluZyBcMC4KCkQnb2guIFllYWgsIHlvdSdkIGhhdmUgdG8gcGFzcyB0 aGUgZGVsaW1pdGVyIGFzIGEgc3RyaW5nIHRvIG1ha2UgdGhpcwpyZWFsbHkgd29yaywgb3IgYWRk IGEgbG9jYWwgYnVmLiBNZWguIFNvbWV0aGluZyBmb3IgdGhlIGZ1dHVyZS4KCk9uIHRoZSBvcmln aW5hbCBwYXRjaCwKClJldmlld2VkLWJ5OiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAaW50ZWwu Y29tPgoKCgoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJjZSBHcmFwaGljcyBDZW50 ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaWd0LWRl diBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2Cg==