From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 187D6F8E499 for ; Fri, 17 Apr 2026 03:35:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6A02610E283; Fri, 17 Apr 2026 03:35:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ZZ9kBhm5"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by gabe.freedesktop.org (Postfix) with ESMTPS id C7EB610E283 for ; Fri, 17 Apr 2026 03:35:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776396926; x=1807932926; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Adc0XWY4B5D/jd/Xpr1/orw71+PJ+zf/XWm/bUoKpc8=; b=ZZ9kBhm57e5QyhY8UMA8iXV9tbuzwM5EgUgD/Aa1f7TW5CE7bxdXBsgr WV9vZ2esMlrztKOgTqOR3RIdgUq/FZMOsuJOFHErS851T8O15qZO4/zYD Y0/v6dk4/lUxY+bOocKh7mKqaXCdIlGiRHxOSKyVVAdHBMBGwHAMnLEbp 1RSso7U9SRrE9pzPSKvS55KeYiEdi/8ij86C0IsGv0ZfsX4dHx5qXJ4yx qxNyPwot/ejWo1PgfhIE6X+EgJqA57DbxSIF6PRs8fjojNU+ITuBvh6E2 rXDMVWqHxuLgu1veuwqUosgeDT08bRUZoOf/p5fNKAKPCjGFy3r+9BJB7 w==; X-CSE-ConnectionGUID: 5V+cU5B7SVO2wj4nJQHEtg== X-CSE-MsgGUID: 44hWDi6/Tka7Ay56wS6vFw== X-IronPort-AV: E=McAfee;i="6800,10657,11761"; a="94811838" X-IronPort-AV: E=Sophos;i="6.23,183,1770624000"; d="scan'208";a="94811838" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2026 20:35:26 -0700 X-CSE-ConnectionGUID: 8jLktkjbTRGjg9zA70tsdw== X-CSE-MsgGUID: f4FssVcBQ6a2FaeXOs3s8Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,183,1770624000"; d="scan'208";a="230066249" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.125.136.209]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2026 20:35:25 -0700 Date: Thu, 16 Apr 2026 20:35:24 -0700 Message-ID: <87y0im6yyr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH v2 i-g-t] lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format In-Reply-To: <4d5988f1-09a5-4e48-b133-2b1f2440cb5a@intel.com> References: <20260416184826.913464-1-ashutosh.dixit@intel.com> <4d5988f1-09a5-4e48-b133-2b1f2440cb5a@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 16 Apr 2026 19:09:57 -0700, Shekhar Chauhan wrote: > > On 4/17/2026 0:18, Ashutosh Dixit wrote: > > Support for CRI 192B_MPEC8LL_NOA16 OAM format was previously missed > > out. Add it. > > > > v2: Fix B/C counter accumulation (Shekhar C) > > > > Signed-off-by: Ashutosh Dixit > > --- > > lib/xe/oa-configs/oa-metricset-codegen.py | 13 +++++++++++- > > lib/xe/xe_oa.c | 24 +++++++++++++++++++++++ > > 2 files changed, 36 insertions(+), 1 deletion(-) > > > > diff --git a/lib/xe/oa-configs/oa-metricset-codegen.py b/lib/xe/oa-configs/oa-metricset-codegen.py > > index c5c7a2c8d4..b44d4d73af 100644 > > The patch itself makes sense now. But there's one change missing in 2 > places. The function "intel_xe_perf_read_record_timestamp" and > "intel_xe_perf_read_record_timestamp_raw" both need this new format > recognised there else they'll still fallback to "assert(0)". > > Other than that, this looks fine and we can merge it after that. OK, thanks again, fixed in v3.