Re: [PATCH i-g-t 1/2] lib/xe/oa: Add CRI metrics XML

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 30 Mar 2026 12:54:31 -0700, Umesh Nerlige Ramappa wrote:
>

Hi Umesh,

> > diff --git a/lib/xe/oa-configs/oa-metricset-codegen.py b/lib/xe/oa-configs/oa-metricset-codegen.py
> > index 922fae58cb..c5c7a2c8d4 100644
> > --- a/lib/xe/oa-configs/oa-metricset-codegen.py
> > +++ b/lib/xe/oa-configs/oa-metricset-codegen.py
> > @@ -138,9 +138,9 @@ def generate_metric_sets(args, gen):
> >                     metric_set->c_offset = metric_set->b_offset + 8;
> >                     metric_set->perfcnt_offset = metric_set->c_offset + 8;
> >                 """))
> > -        elif gen.chipset == "lnl" or gen.chipset == "bmg" or gen.chipset == "ptl":
> > +        elif gen.chipset == "lnl" or gen.chipset == "bmg" or gen.chipset == "ptl" or gen.chipset == "cri":
> >             # See intel_xe_perf_accumulate_reports for the offsets
> > -            if set.oa_format == "128B_MPEC8_NOA16":
> > +            if set.oa_format == "128B_MPEC8_NOA16" or set.oa_format == "128B_MERT_PEC8":
>
> Since you are handling multiple platforms with this if block, I would
> change it to:
>
> if set.oa_format == "128B_MPEC8_NOA16" or
>   (set.oa_format == "128B_MERT_PEC8" and gen.chipset == "cri"):
>
> Rest looks good.
>
> >                 c(textwrap.dedent("""\
> >                     metric_set->perf_oa_format = XE_OAM_FORMAT_MPEC8u32_B8_C8;


I think this is fine as is. First, MERT may be present on other platforms
too (other than cri). So I am thinking the format is specific to MERT,
rather than to any particular platform. So we just say here that both
"128B_MERT_PEC8" and "128B_MPEC8_NOA16" formats in the XML's get mapped
into XE_OAM_FORMAT_MPEC8u32_B8_C8 in the code. So the formats themselves
are not platform specific. So I would like this to be format related,
rather than platform related.

So I think it is ok as is. Let me know what you think.

Thanks.
--
Ashutosh




> >
> > diff --git a/lib/xe/oa-configs/oa_guid_registry.py b/lib/xe/oa-configs/oa_guid_registry.py
> > index 55c4968161..75939cfa2b 100644
> > --- a/lib/xe/oa-configs/oa_guid_registry.py
> > +++ b/lib/xe/oa-configs/oa_guid_registry.py
> > @@ -104,6 +104,7 @@ class Registry:
> >                            'LNL',
> >                            'BMG',
> >                            'PTL',
> > +                           'CRI',
> >                           )
> >         if name in known_chipsets:
> >             return name
> > diff --git a/lib/xe/oa-configs/update-guids.py b/lib/xe/oa-configs/update-guids.py
> > index c3f5a37c6e..d55958a0c0 100755
> > --- a/lib/xe/oa-configs/update-guids.py
> > +++ b/lib/xe/oa-configs/update-guids.py
> > @@ -168,6 +168,7 @@ chipsets = [ 'hsw',
> >              'lnl',
> >              'bmg',
> >              'ptl',
> > +             'cri',
> > ]
> >
> > for chipset in chipsets:
> > --
> > 2.48.1
> >