From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E94621061B18 for ; Mon, 30 Mar 2026 21:56:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7EAD510E02B; Mon, 30 Mar 2026 21:56:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="lDkWdo+4"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F94010E02B for ; Mon, 30 Mar 2026 21:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1774907779; x=1806443779; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=gNTo7cdts2xFpBDYQ11ZMAoIN1LtupWV0VaYwr5NTWo=; b=lDkWdo+4SqOCpA/QVviZl3QXqrhG/+R/GWulJX4tfwRgl8bS3thEgVrr bz8PDoAzh/Ds7wHJ58vvGVyH/Ccu22nhbO4b2wqBv567l5AHaYaHwKDNC I7tH8FLAhZnxAoMoceZNd4qpkwDYnZWUAHdAM7zAbQtaF11h44jhHaQi4 V2hX/ZleuKEsr+FxzUP38jEGw7vQ1/PvKAJsiJMrfKuuMHUQUfjq+TNbl jpo5WcDKDCGpMU4dZc1sNLWPz4Uj2w2yYul9U9zlDQR5XL+gqXL88ao/F aS4/B9ergSve9BzufeV4+YfTsbcqf2G4b8Hym+2M4NllQBoCVNQkMJe0w w==; X-CSE-ConnectionGUID: JMsdBujcSU+dAIU/hMT8cA== X-CSE-MsgGUID: /3hUlBMBQ7CkZthOxwsGpg== X-IronPort-AV: E=McAfee;i="6800,10657,11744"; a="79812726" X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="79812726" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 14:56:18 -0700 X-CSE-ConnectionGUID: i4Te4CezRIWQIxEn9If0jw== X-CSE-MsgGUID: TlwAU6YOQFKhV69WwEC8GA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,150,1770624000"; d="scan'208";a="221306779" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.241.243.110]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2026 14:56:19 -0700 Date: Mon, 30 Mar 2026 14:56:18 -0700 Message-ID: <87y0j9x9q5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: , , Subject: Re: [PATCH i-g-t 1/2] lib/xe/oa: Add CRI metrics XML In-Reply-To: References: <20260224004151.1836090-1-ashutosh.dixit@intel.com> <20260224004151.1836090-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Mon, 30 Mar 2026 12:54:31 -0700, Umesh Nerlige Ramappa wrote: > Hi Umesh, > > diff --git a/lib/xe/oa-configs/oa-metricset-codegen.py b/lib/xe/oa-configs/oa-metricset-codegen.py > > index 922fae58cb..c5c7a2c8d4 100644 > > --- a/lib/xe/oa-configs/oa-metricset-codegen.py > > +++ b/lib/xe/oa-configs/oa-metricset-codegen.py > > @@ -138,9 +138,9 @@ def generate_metric_sets(args, gen): > > metric_set->c_offset = metric_set->b_offset + 8; > > metric_set->perfcnt_offset = metric_set->c_offset + 8; > > """)) > > - elif gen.chipset == "lnl" or gen.chipset == "bmg" or gen.chipset == "ptl": > > + elif gen.chipset == "lnl" or gen.chipset == "bmg" or gen.chipset == "ptl" or gen.chipset == "cri": > > # See intel_xe_perf_accumulate_reports for the offsets > > - if set.oa_format == "128B_MPEC8_NOA16": > > + if set.oa_format == "128B_MPEC8_NOA16" or set.oa_format == "128B_MERT_PEC8": > > Since you are handling multiple platforms with this if block, I would > change it to: > > if set.oa_format == "128B_MPEC8_NOA16" or > (set.oa_format == "128B_MERT_PEC8" and gen.chipset == "cri"): > > Rest looks good. > > > c(textwrap.dedent("""\ > > metric_set->perf_oa_format = XE_OAM_FORMAT_MPEC8u32_B8_C8; I think this is fine as is. First, MERT may be present on other platforms too (other than cri). So I am thinking the format is specific to MERT, rather than to any particular platform. So we just say here that both "128B_MERT_PEC8" and "128B_MPEC8_NOA16" formats in the XML's get mapped into XE_OAM_FORMAT_MPEC8u32_B8_C8 in the code. So the formats themselves are not platform specific. So I would like this to be format related, rather than platform related. So I think it is ok as is. Let me know what you think. Thanks. -- Ashutosh > > > > diff --git a/lib/xe/oa-configs/oa_guid_registry.py b/lib/xe/oa-configs/oa_guid_registry.py > > index 55c4968161..75939cfa2b 100644 > > --- a/lib/xe/oa-configs/oa_guid_registry.py > > +++ b/lib/xe/oa-configs/oa_guid_registry.py > > @@ -104,6 +104,7 @@ class Registry: > > 'LNL', > > 'BMG', > > 'PTL', > > + 'CRI', > > ) > > if name in known_chipsets: > > return name > > diff --git a/lib/xe/oa-configs/update-guids.py b/lib/xe/oa-configs/update-guids.py > > index c3f5a37c6e..d55958a0c0 100755 > > --- a/lib/xe/oa-configs/update-guids.py > > +++ b/lib/xe/oa-configs/update-guids.py > > @@ -168,6 +168,7 @@ chipsets = [ 'hsw', > > 'lnl', > > 'bmg', > > 'ptl', > > + 'cri', > > ] > > > > for chipset in chipsets: > > -- > > 2.48.1 > >