From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A779ECD6E56 for ; Thu, 5 Sep 2024 16:54:34 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 611FE10E912; Thu, 5 Sep 2024 16:54:34 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="CNh5v/i1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D3F810E912 for ; Thu, 5 Sep 2024 16:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725555273; x=1757091273; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=TvJEcO9BK9gvvjrCeLJehgl42ZVzTKvHRjijB6Xhih8=; b=CNh5v/i15jtjvIpL7A2n73QQNSFqnk5S/GOLhKUBtQ1EbLbs4nborAvs AhJhDWGfmPjLevG0ShzvIU3/HPjmEXsf0mwUslK8KzzCz7ssiVS0CbEvz h3/6ouEniGvtEVrt/cAJED0cEIsCpXyo82kfXIkrTVie+faipPgvSC7Sq cSCXVZYZbp5UaNG6VW8OGAnRdXWw/J4yT/oFEYqZgJsqdt0CFpXz+/e1M 7lpte6/nviISEjC5Gljaj84lHvaWKMSAi/MiIs0q3yu8iJd2xU7nnLEuo EjfTrZL07DTzFvwKDY+eg2LrVgjaUxmtSU4sL2URAxPqGWSadKwxtSK7z w==; X-CSE-ConnectionGUID: PN6GUulbSza0nHnZnVKw5g== X-CSE-MsgGUID: RgflmvVpSBCq9jrHdVB1Kw== X-IronPort-AV: E=McAfee;i="6700,10204,11186"; a="24162656" X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="24162656" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 09:54:33 -0700 X-CSE-ConnectionGUID: DWZmGiitQJuAIyY4nyCwGg== X-CSE-MsgGUID: CnxpRolYTQSmZK1uCWSbaA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,205,1719903600"; d="scan'208";a="65335025" Received: from gantonix-mobl.amr.corp.intel.com (HELO adixit-arch.intel.com) ([10.125.226.122]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 09:54:32 -0700 Date: Thu, 05 Sep 2024 09:36:50 -0700 Message-ID: <87y146xdjx.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: =?ISO-8859-1?Q?Jos=E9?= Roberto de Souza Cc: Subject: Re: [PATCH i-g-t v3 3/4] xe/oa: Update scripts to support BMG In-Reply-To: <20240903205457.109320-3-jose.souza@intel.com> References: <20240903205457.109320-1-jose.souza@intel.com> <20240903205457.109320-3-jose.souza@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Tue, 03 Sep 2024 13:54:56 -0700, Jos=E9 Roberto de Souza wrote: > > diff --git a/lib/xe/xe_oa.c b/lib/xe/xe_oa.c > index 4764ed1fcf..a7df68488c 100644 > --- a/lib/xe/xe_oa.c > +++ b/lib/xe/xe_oa.c > @@ -38,6 +38,7 @@ > #include "xe_oa_metrics_mtlgt3.h" > #include "xe_oa_metrics_pvc.h" > #include "xe_oa_metrics_lnl.h" > +#include "xe_oa_metrics_bmg.h" > > static struct intel_xe_perf_logical_counter_group * > intel_xe_perf_logical_counter_group_new(struct intel_xe_perf *perf, > @@ -300,8 +301,10 @@ intel_xe_perf_for_devinfo(uint32_t device_id, > } else if (devinfo->is_pontevecchio) { > perf->devinfo.eu_threads_count =3D 8; > intel_xe_perf_load_metrics_pvc(perf); > - } else if (intel_graphics_ver(device_id) >=3D IP_VER(20, 0)) { > + } else if (devinfo->is_lunarlake) { > intel_xe_perf_load_metrics_lnl(perf); > + } else if (devinfo->is_battlemage) { > + intel_xe_perf_load_metrics_bmg(perf); I made a small change to this patch here: https://patchwork.freedesktop.org/patch/612713/?series=3D138273&rev=3D1 Basically retaining the "else if (intel_graphics_ver(device_id) >=3D IP_VER(20, 0))" line, so that we can have LNL as the default platform for Xe2+. Since generally LNL metrics will work, even for new platforms, at least for the initial checkout, say during power-on's. And if not, we can add a condition for that specific platform, which we anyway need to do with the above code. So may save a little bit of work for the initial checkout. Thanks. -- Ashutosh