From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id D8B1F10E1A1 for ; Fri, 13 May 2022 15:24:15 +0000 (UTC) Date: Fri, 13 May 2022 08:24:13 -0700 Message-ID: <87y1z55uci.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Petri Latvala In-Reply-To: <20220513095300.6785-1-petri.latvala@intel.com> References: <20220513095300.6785-1-petri.latvala@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Subject: Re: [igt-dev] [PATCH i-g-t] lib: Add missing newline in igt_fopen_data's logging List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 13 May 2022 02:53:00 -0700, Petri Latvala wrote: > > Also drive-by, change %s strerror(errno) to the equivalent %m. Hmm didn't know about this one :) Reviewed-by: Ashutosh Dixit > Signed-off-by: Petri Latvala > --- > lib/igt_core.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/lib/igt_core.c b/lib/igt_core.c > index 6dad3c84..ba906ab0 100644 > --- a/lib/igt_core.c > +++ b/lib/igt_core.c > @@ -2929,8 +2929,7 @@ FILE *__igt_fopen_data(const char* igt_srcdir, const char* igt_datadir, > } > > if (!fp) > - igt_critical("Could not open data file \"%s\": %s", filename, > - strerror(errno)); > + igt_critical("Could not open data file \"%s\": %m\n", filename); > > return fp; > } > -- > 2.30.2 >