From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Zbigniew Kempczyński" <zbigniew.kempczynski@intel.com>
Cc: igt-dev@lists.freedesktop.org, Petri Latvala <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/i915/intel_memory_region: Handle -ENODEV path individually
Date: Mon, 13 Dec 2021 20:33:56 -0800 [thread overview]
Message-ID: <87y24n9557.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20211213181208.159531-1-zbigniew.kempczynski@intel.com>
On Mon, 13 Dec 2021 10:12:08 -0800, Zbigniew Kempczyński wrote:
>
> As Ashutosh noticed I've handled errors from the kernel too wide
> packing it to same error bag and returning system memory region in this
> case. That's of course is wrong and can lead to return system memory on
> discrete if invalid arguments would be passed to the query.
>
> Return previous behavior of query memory regions handling -ENODEV path
> individually. For this error lets assume we got kernel which doesn't
> support this query yet so returning system memory region is a reasonable
> choice because this region exists for all of i915 gens.
Looks good now so this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
But could you please point out where the -ENODEV return code is coming
from and which stable kernel. Thanks.
next prev parent reply other threads:[~2021-12-14 4:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-13 18:12 [igt-dev] [PATCH i-g-t] lib/i915/intel_memory_region: Handle -ENODEV path individually Zbigniew Kempczyński
2021-12-13 19:14 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-12-14 0:36 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-12-14 7:48 ` Zbigniew Kempczyński
2021-12-14 17:51 ` Vudum, Lakshminarayana
2021-12-14 4:33 ` Dixit, Ashutosh [this message]
2021-12-14 5:04 ` [igt-dev] [PATCH i-g-t] " Dixit, Ashutosh
2021-12-14 17:18 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y24n9557.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
--cc=zbigniew.kempczynski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox