From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga04.intel.com (mga04.intel.com [192.55.52.120])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9C5DF6E507
 for <igt-dev@lists.freedesktop.org>; Fri, 22 Oct 2021 00:15:10 +0000 (UTC)
Date: Thu, 21 Oct 2021 17:12:26 -0700
Message-ID: <87y26l9atx.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <20211021073321.GC3640@zkempczy-mobl2>
References: <20211021043508.1158148-1-priyanka.dandamudi@intel.com>
 <20211021043508.1158148-4-priyanka.dandamudi@intel.com>
 <20211021073321.GC3640@zkempczy-mobl2>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t 3/4] lib/igt_gt: Add compute engine
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
Cc: priyanka.dandamudi@intel.com, igt-dev@lists.freedesktop.org, arjun.melkaveri@intel.com, John Harrison <john.c.harrison@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
List-ID: <igt-dev@lists.freedesktop.org>

On Thu, 21 Oct 2021 00:33:21 -0700, Zbigniew Kempczy=F1ski wrote:
>
> On Thu, Oct 21, 2021 at 10:05:07AM +0530, priyanka.dandamudi@intel.com wr=
ote:
> > From: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> >
> > Add compute (CCS) engine. Add this to the IGT
> > structure to allow gem tests to execute.
> >
> > Signed-off-by: Stuart Summers <stuart.summers@intel.com>
> > Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> > Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi@intel.com>
> > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > Cc: Arjun Melkaveri <arjun.melkaveri@intel.com>
> > ---
> >  lib/igt_gt.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> > index a0ba04cc..80fb65ca 100644
> > --- a/lib/igt_gt.c
> > +++ b/lib/igt_gt.c
> > @@ -604,6 +604,10 @@ const struct intel_execution_engine2 intel_executi=
on_engines2[] =3D {
> >	{ "vcs1", I915_ENGINE_CLASS_VIDEO, 1, I915_EXEC_BSD | I915_EXEC_BSD_RIN=
G2 },
> >	{ "vcs2", I915_ENGINE_CLASS_VIDEO, 2, -1 },
> >	{ "vecs0", I915_ENGINE_CLASS_VIDEO_ENHANCE, 0, I915_EXEC_VEBOX },
> > +	{ "ccs0", I915_ENGINE_CLASS_COMPUTE, 0 , -1},
> > +	{ "ccs1", I915_ENGINE_CLASS_COMPUTE, 1 , -1},
> > +	{ "ccs2", I915_ENGINE_CLASS_COMPUTE, 2 , -1},
> > +	{ "ccs3", I915_ENGINE_CLASS_COMPUTE, 3 , -1},
>
> LGTM,
>
> Reviewed-by: Zbigniew Kempczy=F1ski <zbigniew.kempczynski@intel.com>

Is this correct? Isn't intel_execution_engines2 a list of just the legacy
engines? I don't think compute engines (which may vary in number) can be
added to the list of legacy engines. Isn't it true that compute engines can
only be accessed by querying the present engines dynamically (using
something like intel_ctx_create_all_physical())?

For example see:

/**
 * __for_each_static_engine:
 * @e__: struct intel_execution_engine2 iterator
 *
 * Iterates over each of the statically defined (legacy) engines.
 */
#define __for_each_static_engine(e__) \
        for ((e__) =3D intel_execution_engines2; (e__)->name[0]; (e__)++)