From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2260B6E9D3
 for <igt-dev@lists.freedesktop.org>; Thu, 19 Aug 2021 20:00:45 +0000 (UTC)
Date: Thu, 19 Aug 2021 13:00:43 -0700
Message-ID: <87y28xb3x0.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
In-Reply-To: <87zgtdb4kq.wl-ashutosh.dixit@intel.com>
References: <20210819061029.610090-1-mastanx.katragadda@intel.com>
 <87zgtdb4kq.wl-ashutosh.dixit@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [igt-dev] [i-g-t] tests/i915/exec_balancer: Added Skip
 invalid-bonds
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
To: Mastan Katragadda <mastanx.katragadda@intel.com>
Cc: igt-dev@lists.freedesktop.org, tejaskumarx.surendrakumar.upadhyay@intel.com, jason@jlekstrand.net, matthew.brost@intel.com
List-ID: <igt-dev@lists.freedesktop.org>

On Thu, 19 Aug 2021 12:46:29 -0700, Dixit, Ashutosh wrote:
>
> On Wed, 18 Aug 2021 23:10:29 -0700, Mastan Katragadda wrote:
> >
> > Added skip which ever gen12+ platforms not supporing bonding.
> >
> > Disable bonding on gen12+ platforms aside from ones already supported by
> > the i915 - TGL, RKL, and ADL-S.
> >
> > Link: https://cgit.freedesktop.org/drm-tip/commit/?id=ce7e75c7ef1bf8ea3d947da8c674d2f40fd7d73
> >
> > Signed-off-by: Mastan Katragadda <mastanx.katragadda@intel.com>
> > ---
> >  tests/i915/gem_exec_balancer.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> > index 2f98950b..2d9c1a53 100644
> > --- a/tests/i915/gem_exec_balancer.c
> > +++ b/tests/i915/gem_exec_balancer.c
> > @@ -349,6 +349,10 @@ static void invalid_bonds(int i915)
> >		bonds[n].num_bonds = 1;
> >	}
> >	engines.extensions = to_user_pointer(&bonds);
> > +
> > +	igt_skip_on_f(__set_param_fresh_context(i915, p) == -ENODEV,
> > +			"Bonding not supported\n");
> > +
> >	igt_assert_eq(__set_param_fresh_context(i915, p), 0);
>
> int ret;
>
> ret = __set_param_fresh_context(i915, p);
> igt_skip_on_f(ret  == -ENODEV, "Bonding not supported\n");
> igt_assert_eq(ret, 0);
>
> Also, is this the only test failing in gem_exec_balancer when bonding is
> not supported? Or are there others too? Thanks.

Looks like the invalid_balancer test introduced in 17914147aaf will also
fail since kernel will now return -ENODEV and not -EINVAL?