From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Subject: Re: [igt-dev] [PATCH i-g-t 03/16] Add basic PXP testing of buffer and context alloc
Date: Sat, 15 May 2021 19:51:15 -0700 [thread overview]
Message-ID: <87y2cfie70.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <BYAPR11MB37845ECF7EF6ABBC7E169F608A2F9@BYAPR11MB3784.namprd11.prod.outlook.com>
On Sat, 15 May 2021 16:58:24 -0700, Teres Alexis, Alan Previn wrote:
>
> I have been using checkpatch.pl on last few revs with zero issues. One caveat though and I just realize this now:
> - when I run checkpatch "--no-tree -f my_modified_file.c", I don't get any warnings.
> - when I run but running on the patches I get warnings about "exceeding 100 columns".
>
> What is the official hard rule? Are we at 120, 100 or 80?
IGT follows the kernel coding style. The kernel originally had a 80 char
width limit which was recently increased to 100 that is why checkpatch now
complains about 100.
So yes it's either 80 or 100 however you want to do it. But the official
hard limit is now 100 I'd think. So I'd fix it to be within one of those
widths.
>
> ...alan
>
> -----Original Message-----
> From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> Sent: Saturday, May 15, 2021 4:16 PM
> To: Teres Alexis, Alan Previn <alan.previn.teres.alexis@intel.com>
> Cc: igt-dev@lists.freedesktop.org
> Subject: Re: [igt-dev] [PATCH i-g-t 03/16] Add basic PXP testing of buffer and context alloc
>
> On Fri, 14 May 2021 02:40:26 -0700, Teres Alexis, Alan Previn wrote:
> >
> >
> > Okay - i will fix them all and push a new rev.
>
> Mostly coding style looks good now but an easy way to check for style/indendation issues in the code is to run checkpatch from the kernel on the IGT patches and fix all issues which are not kernel specific (and also ignore those which don't make sense):
>
> https://github.com/torvalds/linux/blob/master/scripts/checkpatch.pl
>
>
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2021-05-16 2:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-14 6:49 [igt-dev] [PATCH i-g-t 00/16] Introduce PXP Test Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 01/16] Sync i915_drm.h UAPI from kernel Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 02/16] Add PXP UAPI support in i915_drm.h Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 03/16] Add basic PXP testing of buffer and context alloc Alan Previn
2021-05-14 9:00 ` Michal Wajdeczko
2021-05-14 9:40 ` Teres Alexis, Alan Previn
2021-05-15 23:15 ` Dixit, Ashutosh
2021-05-15 23:58 ` Teres Alexis, Alan Previn
2021-05-16 2:51 ` Dixit, Ashutosh [this message]
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 04/16] Perform a regular 3d copy as a control checkpoint Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 05/16] Add PXP attribute support in batchbuffer and buffer_ops libs Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 06/16] Add MI_SET_APPID instruction definition Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 07/16] Enable protected session cmd in gen12_render_copyfunc Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 08/16] Add subtest to copy raw source to protected dest Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 09/16] Add test where both src and dest are protected Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 10/16] Verify PXP teardown occured through suspend-resume Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 11/16] Verify execbuf fails with stale PXP context after teardown Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 12/16] Verify execbuf fails with stale PXP buffer " Alan Previn
2021-05-15 19:50 ` Teres Alexis, Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 13/16] Verify execbuf ok with stale prot-buff and regular context Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 14/16] Ensure RESET_STAT reports invalidated protected context Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 15/16] Verify protected surfaces are dma buffer sharable Alan Previn
2021-05-14 6:49 ` [igt-dev] [PATCH i-g-t 16/16] tests/i915_pxp: CRC validation for display tests Alan Previn
2021-05-14 7:28 ` [igt-dev] ✓ Fi.CI.BAT: success for Introduce PXP Test (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2cfie70.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=alan.previn.teres.alexis@intel.com \
--cc=igt-dev@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox