From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55DF1F8D755 for ; Thu, 16 Apr 2026 18:50:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EEBCF10E1D9; Thu, 16 Apr 2026 18:50:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="H3rGJECo"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 25C0810E1D9 for ; Thu, 16 Apr 2026 18:50:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1776365415; x=1807901415; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Z1ewfUdtt9V/ZQsHo/Z1z+xdIFdi6q2su2RXt7XKJrE=; b=H3rGJECoXiFW9WZX7RGt6yqR3oqUbdrdQi6ZAIlUSe/tAi46Vl8xO4qV NfjTeb6ChF6H8qKT/WUA86jICuZ3rW9Lc8dEIWmMgsUua0g9l+Z/6di/c iG4thu9447aFvOd5yZLmdpe0zZWMCrPxzWvO532SRlV9GEBO32uhLZEUV Hy/hiZT8+UD7n11JxGXunIz7TGkKQuwTe/XQWkeoEeUjv1+hBYnbaxefh ZEDW6Qm9oGzLgA/lo58nv6qST/4A+GTthmGzaJn0RpXB83gqy/pZcZIT6 s5vpQRl1NNYfpiA1nSNq1ecjTSnLUQEqkhSmCCm8PDxY6ccLdJC8nCO8T Q==; X-CSE-ConnectionGUID: 3m1/KWjqRM+ANOAaY2hYkg== X-CSE-MsgGUID: A1kqjJt/SoCk+fssXJ5SIA== X-IronPort-AV: E=McAfee;i="6800,10657,11761"; a="88828576" X-IronPort-AV: E=Sophos;i="6.23,181,1770624000"; d="scan'208";a="88828576" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2026 11:50:14 -0700 X-CSE-ConnectionGUID: teEyrtUHTNuG8bsRmE742w== X-CSE-MsgGUID: sv3mUXYhSVWS/BVGNM9FHg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.23,181,1770624000"; d="scan'208";a="228145279" Received: from unknown (HELO adixit-MOBL3.intel.com) ([10.125.136.209]) by fmviesa008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2026 11:50:14 -0700 Date: Thu, 16 Apr 2026 11:50:13 -0700 Message-ID: <87zf327na2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: Subject: Re: [PATCH i-g-t] lib/xe/oa: Add support for 192B_MPEC8LL_NOA16 OAM format In-Reply-To: <9ff0775d-e568-46db-abb8-efad79ecb387@intel.com> References: <20260415215257.898995-1-ashutosh.dixit@intel.com> <9ff0775d-e568-46db-abb8-efad79ecb387@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Wed, 15 Apr 2026 21:31:23 -0700, Shekhar Chauhan wrote: > > > @@ -875,6 +875,30 @@ void intel_xe_perf_accumulate_reports(struct intel_xe_perf_accumulator *acc, > > break; > > + case XE_OAM_FORMAT_MPEC8u64_B8_C8: > > + /* 64 bit timestamp */ > > + if (perf->devinfo.oa_timestamp_shift >= 0) > > + deltas[idx++] += (end64[1] - start64[1]) << perf->devinfo.oa_timestamp_shift; > > + else > > + deltas[idx++] += (end64[1] - start64[1]) >> (-perf->devinfo.oa_timestamp_shift); > > + > > + /* 64 bit clock */ > > + deltas[idx++] += end64[3] - start64[3]; > > + > > + /* 8x 64bit MPEC counters */ > > + for (i = 0; i < 8; i++) > > + deltas[idx++] += end64[4 + i] - start64[4 + i]; > > + > > + > I feel the below increments are wrong. The added format is of 64bit. > > /* 8x 32bit B counters */ > > + for (i = 0; i < 8; i++) > > + accumulate_uint32(start + 16 + i, end + 16 + i, deltas + idx++); > This should be "accumulate_uint32(start + 24 + i, end + 24 + i, deltas + > idx++);" > > + > > + /* 8x 32bit C counters */ > > + for (i = 0; i < 8; i++) > > + accumulate_uint32(start + 24 + i, end + 24 + i, deltas + idx++); > > And this, "accumulate_uint32(start + 32 + i, end + 32 + i, deltas + idx++);" > > I'm still new to this, so I can be wrong. Maybe help me understand. Other > than this, patch looks fine to me. Good catch, fixed in v2. Thanks!