From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E109CD4F49 for ; Fri, 14 Nov 2025 05:43:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 30EFF10E9B3; Fri, 14 Nov 2025 05:43:35 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ARjmWux+"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1F11A10E9B3 for ; Fri, 14 Nov 2025 05:43:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1763099014; x=1794635014; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=yXPJcOb8hVi4S7osouJXsiYo0n6Dn511AaMQtIs2F5Y=; b=ARjmWux+Exhjxzsko3nEFlczD+HyfrTAac7NUsfMrH89NudPL9jS7sKk 4BjiuBC1Rq+KzjHBDE4Lshobnn+QfsbDNb74uYVI6OQWoh9TSht6TimM8 H8iyxFRKIlFKX6Zhwio4+Lr03iAseJk27ekpTD49groj0K1sdADZMUg4m L29oV1WqCM1JaLz+Qi2Sl2NuJp//VRO92S1BWcr7AWte9dY9Sc3wuDOyP FpyQ0LPqDgGJolmNEGvYn7fsgKLWg7XfSy5V7kBdzDUEKptFuTK2GWuOc WfqRLJ2LLpWPTlGrW/Q2qJPtP+NIUZZg2vyIddqwB3uRApFjofBqrwMxg w==; X-CSE-ConnectionGUID: xKCgbJAiQ3Oti2tEjcfZHw== X-CSE-MsgGUID: z6m6acpASqyBmrnRu0Kdsg== X-IronPort-AV: E=McAfee;i="6800,10657,11612"; a="75797240" X-IronPort-AV: E=Sophos;i="6.19,304,1754982000"; d="scan'208";a="75797240" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2025 21:43:33 -0800 X-CSE-ConnectionGUID: yQ5dFeVpQwGADvryK4bfvA== X-CSE-MsgGUID: OBQgWMXERrWaMSebHy0KQw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.19,304,1754982000"; d="scan'208";a="193809630" Received: from whkemmer-mobl.amr.corp.intel.com (HELO adixit-MOBL3.intel.com) ([10.125.180.71]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2025 21:43:34 -0800 Date: Thu, 13 Nov 2025 21:43:33 -0800 Message-ID: <87zf8ptbi2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Shekhar Chauhan Cc: igt-dev@lists.freedesktop.org, lucas.demarchi@intel.com, balasubramani.vivekanandan@intel.com, kamil.konieczny@linux.intel.com Subject: Re: [PATCH i-g-t v2 1/3] lib: Add NVL-S support In-Reply-To: <20251106153419.1741989-2-shekhar.chauhan@intel.com> References: <20251106153419.1741989-1-shekhar.chauhan@intel.com> <20251106153419.1741989-2-shekhar.chauhan@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Thu, 06 Nov 2025 07:34:17 -0800, Shekhar Chauhan wrote: > > Add NVL-S device info. > > v2: Fix indentation/spacing for PantherLake and Novalake in > lib/intel_chipset.h (Kamil) > > Signed-off-by: Himanshu Girotra > Signed-off-by: Shekhar Chauhan > --- > lib/intel_chipset.h | 4 +++- > lib/intel_device_info.c | 12 ++++++++++++ > 2 files changed, 15 insertions(+), 1 deletion(-) > > diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h > index 2f6bf788a..70ea78464 100644 > --- a/lib/intel_chipset.h > +++ b/lib/intel_chipset.h > @@ -93,6 +93,7 @@ struct intel_device_info { > bool is_lunarlake : 1; > bool is_battlemage : 1; > bool is_pantherlake : 1; > + bool is_novalake: 1; Maybe in this patch novalake should be changed to novalake_s everywhere? > > const struct intel_cmds_info *cmds_info; > const char *codename; > @@ -209,7 +210,8 @@ void intel_check_pch(void); > #define IS_PONTEVECCHIO(devid) (intel_get_device_info(devid)->is_pontevecchio) > #define IS_LUNARLAKE(devid) (intel_get_device_info(devid)->is_lunarlake) > #define IS_BATTLEMAGE(devid) (intel_get_device_info(devid)->is_battlemage) > -#define IS_PANTHERLAKE(devid) (intel_get_device_info(devid)->is_pantherlake) > +#define IS_PANTHERLAKE(devid) (intel_get_device_info(devid)->is_pantherlake) > +#define IS_NOVALAKE(devid) (intel_get_device_info(devid)->is_novalake) > > #define IS_GEN(devid, x) (intel_get_device_info(devid)->graphics_ver == x) > > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c > index a853f9ab4..fe452d50f 100644 > --- a/lib/intel_device_info.c > +++ b/lib/intel_device_info.c > @@ -539,6 +539,16 @@ static const struct intel_device_info intel_pantherlake_info = { > .cmds_info = &xe2_cmds_info, > }; > > +static const struct intel_device_info intel_novalake_info = { > + .graphics_ver = 30, > + .graphics_rel = 04, > + .display_ver = 35, > + .has_4tile = true, > + .is_novalake = true, > + .codename = "novalake", > + .cmds_info = &xe2_cmds_info, > +}; > + > #define INTEL_PCI_ID_INIT(_id, _info) { \ > .vendor_id = 0x8086, .device_id = (_id), \ > .subvendor_id = PCI_MATCH_ANY, .subdevice_id = PCI_MATCH_ANY, \ > @@ -657,6 +667,8 @@ static const struct pci_id_match intel_device_match[] = { > > INTEL_PTL_IDS(INTEL_PCI_ID_INIT, &intel_pantherlake_info), > > + INTEL_NVLS_IDS(INTEL_PCI_ID_INIT, &intel_novalake_info), > + > INTEL_PCI_ID_INIT(PCI_MATCH_ANY, &intel_generic_info), > }; > > -- > 2.51.1 >