From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1FE1B10EB26 for ; Fri, 25 Feb 2022 22:18:22 +0000 (UTC) Date: Fri, 25 Feb 2022 14:18:21 -0800 Message-ID: <87zgmefv4i.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= In-Reply-To: References: <20220224220229.25548-1-ashutosh.dixit@intel.com> MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: quoted-printable Subject: Re: [igt-dev] [PATCH i-g-t] lib/igt_dummyload: Drop ahnd from igt_spin_t List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: igt-dev@lists.freedesktop.org, jasmine.newsome@intel.com Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Fri, 25 Feb 2022 03:29:59 -0800, Zbigniew Kempczy=F1ski wrote: > > On Thu, Feb 24, 2022 at 02:02:29PM -0800, Ashutosh Dixit wrote: > > In 4d9396e67930 we have started storing the opts with which the spin was > > created as part of igt_spin_t. The ahnd stored as part of igt_spin_t is > > therefore redundant. We can get ahnd from opts.ahnd. > > More than redundancy I like to keep opts which comes from the caller > and thus suggests spinner code that's immune. Unfortunatelly we cannot > block this after memcmp using c-syntax (I'm not able to do this). Sorry, didn't follow what you are referring to here? > Anyway, keeping caller vars in opts suggests this so: > > Reviewed-by: Zbigniew Kempczy=F1ski Thanks, but will wait for your reply before merging.