From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9C68D10F2AD
 for <igt-dev@lists.freedesktop.org>; Thu, 24 Feb 2022 06:45:08 +0000 (UTC)
Date: Wed, 23 Feb 2022 22:45:07 -0800
Message-ID: <87zgmgahl8.wl-ashutosh.dixit@intel.com>
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Zbigniew =?ISO-8859-2?Q?Kempczy=F1ski?= <zbigniew.kempczynski@intel.com>
In-Reply-To: <20220223103303.24510-2-zbigniew.kempczynski@intel.com>
References: <20220223103303.24510-1-zbigniew.kempczynski@intel.com>
 <20220223103303.24510-2-zbigniew.kempczynski@intel.com>
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=ISO-8859-2
Content-Transfer-Encoding: quoted-printable
Subject: Re: [igt-dev] [PATCH i-g-t 1/2] lib/intel_allocator: Add safe
 alignment as a default
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On Wed, 23 Feb 2022 02:33:02 -0800, Zbigniew Kempczy=F1ski wrote:
>
> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> index e5666cd4f..ddb8d8c1f 100644
> --- a/lib/intel_batchbuffer.c
> +++ b/lib/intel_batchbuffer.c
> @@ -1360,7 +1360,7 @@ __intel_bb_create(int i915, uint32_t ctx, uint32_t =
size, bool do_relocs,
>		ibb->allocator_handle =3D intel_allocator_open_full(i915, ctx,
>								  start, end,
>								  allocator_type,
> -								  strategy);
> +								  strategy, 0);

Still reviewing but do we need to change ibb->alignment just below? Also
alignment in intel_bb_add_object()?