Re: [igt-dev] [PATCH i-g-t 1/2] i915/gem_tiled_pread_*: Add check for FENCE based tiling support

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Sat, 01 Feb 2020 11:33:46 -0800, Ayaz A Siddiqui wrote:
>
> These tests are verifying integrity of the tiled data read and write operation
> on platforms which supports FENCE based tiling.
>
> A check has been added to skip these tests if FENCES  are not available
> in platform.
> Tests updated in this patch :
> 1. gem_tiled_pread_basic
> 2. gem_tiled_pread_pwrite
>
> Signed-off-by: Ayaz A Siddiqui <ayaz.siddiqui@intel.com>
> ---
>  tests/i915/gem_tiled_pread_basic.c  | 2 +-
>  tests/i915/gem_tiled_pread_pwrite.c | 1 +
>  2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/i915/gem_tiled_pread_basic.c b/tests/i915/gem_tiled_pread_basic.c
> index 1ac9eccd..7cb64410 100644
> --- a/tests/i915/gem_tiled_pread_basic.c
> +++ b/tests/i915/gem_tiled_pread_basic.c
> @@ -124,7 +124,7 @@ igt_simple_main
>	uint32_t devid;
>
>	fd = drm_open_driver(DRIVER_INTEL);
> -
> +	igt_require(gem_available_fences(fd) > 0);
>	handle = create_bo(fd);
>	igt_require(gem_get_tiling(fd, handle, &tiling, &swizzle));
>
> diff --git a/tests/i915/gem_tiled_pread_pwrite.c b/tests/i915/gem_tiled_pread_pwrite.c
> index 0988a4e8..ee163843 100644
> --- a/tests/i915/gem_tiled_pread_pwrite.c
> +++ b/tests/i915/gem_tiled_pread_pwrite.c
> @@ -122,6 +122,7 @@ igt_simple_main
>
>		current_tiling_mode = I915_TILING_X;
>
> +		igt_require(gem_available_fences(fd) > 0);
>		handle = create_bo_and_fill(fd);
>		igt_require(gem_get_tiling(fd, handle, &tiling, &swizzle));

Both these places already have igt_require(gem_get_tiling()) which is
equivalent so I'd say this patch is not requried.

(In any case if you want to introduce igt_require(gem_available_fences())
I'd put it right after drm_open_driver(), not inside the loop).
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev