Re: [PATCH 2/3] tests/unigraf: Fix DRM master and heap memory leaks in tests

[Louis Chauvet <louis.chauvet@bootlin.com>]

On 7/15/26 21:29, Mark Yacoub wrote:
> [Why]
> The unigraf_connectivity test allocates connector array buffers dynamically via
> kms_wait_for_new_connectors and get_array_diff without freeing them before test
> exit, leading to severe heap leaks when executed iteratively. Furthermore, neither
> unigraf_connectivity nor unigraf_lt closed drm_fd upon completion, holding the
> DRM Master lock open indefinitely. On platforms with a running display compositor
> (such as Android's SurfaceFlinger), this leaves the DRM device locked and causes
> subsequent graphics tests to fail with resource busy errors.
> 
> [How]
> Explicitly call free() on already_connected, newly_connected, and diff buffers
> at the end of unigraf_connectivity. Add an igt_fixture cleanup block to call
> close(drm_fd) when tearing down both unigraf_connectivity and unigraf_lt.
> 
> Fixes: c66d08db9177 ("tests/unigraf: Add basic unigraf tests")
> Signed-off-by: Mark Yacoub <markyacoub@google.com>

Reviewed-by: Louis Chauvet <louis.chauvet@bootlin.com>

> ---
>   tests/unigraf/unigraf_connectivity.c | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/tests/unigraf/unigraf_connectivity.c b/tests/unigraf/unigraf_connectivity.c
> index 927ef2d6f..8ae9a2593 100644
> --- a/tests/unigraf/unigraf_connectivity.c
> +++ b/tests/unigraf/unigraf_connectivity.c
> @@ -134,5 +134,13 @@ int igt_main()
>   				     "Invalid connected connector count, expected %d found %d\n",
>   				     max(i, 1), diff_len);
>   		}
> +
> +		free(already_connected);
> +		free(newly_connected);
> +		free(diff);
> +	}
> +
> +	igt_fixture() {
> +		close(drm_fd);
>   	}
>   }