From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id DA33689113 for ; Mon, 20 May 2019 10:38:37 +0000 (UTC) From: "Ser, Simon" Date: Mon, 20 May 2019 10:38:34 +0000 Message-ID: <887d7a08d5c0575eb0671388f7e29ccdde500693.camel@intel.com> References: <20190517160242.28247-1-simon.ser@intel.com> In-Reply-To: Content-Language: en-US Content-ID: <42C5DBF93F05C140822456BB7A9C719C@intel.com> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 1/5] lib/igt_alsa: support all alsa formats List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "igt-dev@lists.freedesktop.org" , "Peres, Martin" List-ID: T24gTW9uLCAyMDE5LTA1LTIwIGF0IDEzOjExICswMzAwLCBNYXJ0aW4gUGVyZXMgd3JvdGU6DQo+ IE9uIDE3LzA1LzIwMTkgMTk6MDIsIFNpbW9uIFNlciB3cm90ZToNCj4gPiBUaGlzIGNvbW1pdCBh ZGRzIGEgbmV3IGZvcm1hdCBhcmd1bWVudCB0byBhbHNhX2NvbmZpZ3VyZV9vdXRwdXQuIFRoaXMg YWxsb3dzDQo+ID4gdGhlIGNhbGxlciB0byBkZWNpZGUgdGhlIGZvcm1hdCB1c2VkIGZvciB0aGUg YXVkaW8gc2lnbmFsLg0KPiA+IA0KPiA+IFRoaXMgcmVtb3ZlcyB0aGUgYXNzdW1wdGlvbiB0aGF0 IHNhbXBsZXMgYXJlIFMxNl9MRSBpdGVtcyBpbiBpZ3RfYWxzYS4gVGhlDQo+ID4gYWxzYSBmdW5j dGlvbiBzbmRfcGNtX2Zvcm1hdF9waHlzaWNhbF93aWR0aCBpcyB1c2VkIGluc3RlYWQgb2Ygc2l6 ZW9mKHNob3J0KS4NCj4gPiBUaGlzIGFsc28gcmVtb3ZlcyB0aGUgdGhlb3JpY2FsbHkgaW5jb3Jy ZWN0IGFzc3VtcHRpb24gdGhhdCBzaXplb2Yoc2hvcnQpID09DQo+ID4gc2l6ZW9mKGludDE2X3Qp Lg0KPiA+IA0KPiA+IFJpZ2h0IG5vdyBTMTZfTEUgaXMgaGFyZGNvZGVkIGluIHRoZSB0ZXN0LiBU ZXN0cyB3aXRoIG90aGVyIGZvcm1hdHMgd2lsbCBiZQ0KPiA+IGFkZGVkIGluIGZ1dHVyZSBjb21t aXRzLg0KPiA+IA0KPiA+IFNpZ25lZC1vZmYtYnk6IFNpbW9uIFNlciA8c2ltb24uc2VyQGludGVs LmNvbT4NCj4gPiAtLS0NCj4gPiAgbGliL2lndF9hbHNhLmMgICAgICAgIHwgMjMgKysrKysrKysr KysrKy0tLS0tLS0tLS0NCj4gPiAgbGliL2lndF9hbHNhLmggICAgICAgIHwgIDcgKysrKy0tLQ0K PiA+ICB0ZXN0cy9rbXNfY2hhbWVsaXVtLmMgfCAgNyArKysrLS0tDQo+ID4gIDMgZmlsZXMgY2hh bmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAt LWdpdCBhL2xpYi9pZ3RfYWxzYS5jIGIvbGliL2lndF9hbHNhLmMNCj4gPiBpbmRleCAyOGE4NjZl MGVlNzQuLjJkZmI4Y2NkM2FkOSAxMDA2NDQNCj4gPiAtLS0gYS9saWIvaWd0X2Fsc2EuYw0KPiA+ ICsrKyBiL2xpYi9pZ3RfYWxzYS5jDQo+ID4gQEAgLTI3LDcgKzI3LDYgQEANCj4gPiAgI2luY2x1 ZGUgImNvbmZpZy5oIg0KPiA+ICANCj4gPiAgI2luY2x1ZGUgPGxpbWl0cy5oPg0KPiA+IC0jaW5j bHVkZSA8YWxzYS9hc291bmRsaWIuaD4NCj4gPiAgDQo+ID4gICNpbmNsdWRlICJpZ3RfYWxzYS5o Ig0KPiA+ICAjaW5jbHVkZSAiaWd0X2F1eC5oIg0KPiA+IEBAIC00NywxMCArNDYsMTEgQEANCj4g PiAgc3RydWN0IGFsc2Egew0KPiA+ICAJc25kX3BjbV90ICpvdXRwdXRfaGFuZGxlc1tIQU5ETEVT X01BWF07DQo+ID4gIAlpbnQgb3V0cHV0X2hhbmRsZXNfY291bnQ7DQo+ID4gKwlzbmRfcGNtX2Zv cm1hdF90IG91dHB1dF9mb3JtYXQ7DQo+ID4gIAlpbnQgb3V0cHV0X3NhbXBsaW5nX3JhdGU7DQo+ ID4gIAlpbnQgb3V0cHV0X2NoYW5uZWxzOw0KPiA+ICANCj4gPiAtCWludCAoKm91dHB1dF9jYWxs YmFjaykodm9pZCAqZGF0YSwgc2hvcnQgKmJ1ZmZlciwgaW50IHNhbXBsZXMpOw0KPiA+ICsJaW50 ICgqb3V0cHV0X2NhbGxiYWNrKSh2b2lkICpkYXRhLCB2b2lkICpidWZmZXIsIGludCBzYW1wbGVz KTsNCj4gPiAgCXZvaWQgKm91dHB1dF9jYWxsYmFja19kYXRhOw0KPiA+ICAJaW50IG91dHB1dF9z YW1wbGVzX3RyaWdnZXI7DQo+ID4gIH07DQo+ID4gQEAgLTM0Miw4ICszNDIsOCBAQCBib29sIGFs c2FfdGVzdF9vdXRwdXRfY29uZmlndXJhdGlvbihzdHJ1Y3QgYWxzYSAqYWxzYSwgaW50IGNoYW5u ZWxzLA0KPiA+ICAgKiBDb25maWd1cmUgdGhlIG91dHB1dCBkZXZpY2VzIHdpdGggdGhlIGNvbmZp Z3VyYXRpb24gc3BlY2lmaWVkIGJ5IEBjaGFubmVscw0KPiA+ICAgKiBhbmQgQHNhbXBsaW5nX3Jh dGUuDQo+ID4gICAqLw0KPiA+IC12b2lkIGFsc2FfY29uZmlndXJlX291dHB1dChzdHJ1Y3QgYWxz YSAqYWxzYSwgaW50IGNoYW5uZWxzLA0KPiA+IC0JCQkgICBpbnQgc2FtcGxpbmdfcmF0ZSkNCj4g PiArdm9pZCBhbHNhX2NvbmZpZ3VyZV9vdXRwdXQoc3RydWN0IGFsc2EgKmFsc2EsIHNuZF9wY21f Zm9ybWF0X3QgZm10LA0KPiA+ICsJCQkgICBpbnQgY2hhbm5lbHMsIGludCBzYW1wbGluZ19yYXRl KQ0KPiA+ICB7DQo+ID4gIAlzbmRfcGNtX3QgKmhhbmRsZTsNCj4gPiAgCWludCByZXQ7DQo+ID4g QEAgLTM1NCwxMyArMzU0LDE0IEBAIHZvaWQgYWxzYV9jb25maWd1cmVfb3V0cHV0KHN0cnVjdCBh bHNhICphbHNhLCBpbnQgY2hhbm5lbHMsDQo+ID4gIAlmb3IgKGkgPSAwOyBpIDwgYWxzYS0+b3V0 cHV0X2hhbmRsZXNfY291bnQ7IGkrKykgew0KPiA+ICAJCWhhbmRsZSA9IGFsc2EtPm91dHB1dF9o YW5kbGVzW2ldOw0KPiA+ICANCj4gPiAtCQlyZXQgPSBzbmRfcGNtX3NldF9wYXJhbXMoaGFuZGxl LCBTTkRfUENNX0ZPUk1BVF9TMTZfTEUsDQo+ID4gKwkJcmV0ID0gc25kX3BjbV9zZXRfcGFyYW1z KGhhbmRsZSwgZm10LA0KPiA+ICAJCQkJCSBTTkRfUENNX0FDQ0VTU19SV19JTlRFUkxFQVZFRCwN Cj4gPiAgCQkJCQkgY2hhbm5lbHMsIHNhbXBsaW5nX3JhdGUsDQo+ID4gIAkJCQkJIHNvZnRfcmVz YW1wbGUsIGxhdGVuY3kpOw0KPiA+ICAJCWlndF9hc3NlcnQocmV0ID49IDApOw0KPiA+ICAJfQ0K PiA+ICANCj4gPiArCWFsc2EtPm91dHB1dF9mb3JtYXQgPSBmbXQ7DQo+ID4gIAlhbHNhLT5vdXRw dXRfY2hhbm5lbHMgPSBjaGFubmVsczsNCj4gPiAgCWFsc2EtPm91dHB1dF9zYW1wbGluZ19yYXRl ID0gc2FtcGxpbmdfcmF0ZTsNCj4gPiAgfQ0KPiA+IEBAIC0zNzksNyArMzgwLDcgQEAgdm9pZCBh bHNhX2NvbmZpZ3VyZV9vdXRwdXQoc3RydWN0IGFsc2EgKmFsc2EsIGludCBjaGFubmVscywNCj4g PiAgICogZm9yIGZhaWx1cmUuDQo+ID4gICAqLw0KPiA+ICB2b2lkIGFsc2FfcmVnaXN0ZXJfb3V0 cHV0X2NhbGxiYWNrKHN0cnVjdCBhbHNhICphbHNhLA0KPiA+IC0JCQkJICAgaW50ICgqY2FsbGJh Y2spKHZvaWQgKmRhdGEsIHNob3J0ICpidWZmZXIsIGludCBzYW1wbGVzKSwNCj4gPiArCQkJCSAg IGludCAoKmNhbGxiYWNrKSh2b2lkICpkYXRhLCB2b2lkICpidWZmZXIsIGludCBzYW1wbGVzKSwN Cj4gPiAgCQkJCSAgIHZvaWQgKmNhbGxiYWNrX2RhdGEsIGludCBzYW1wbGVzX3RyaWdnZXIpDQo+ ID4gIHsNCj4gPiAgCWFsc2EtPm91dHB1dF9jYWxsYmFjayA9IGNhbGxiYWNrOw0KPiA+IEBAIC00 MDIsMTIgKzQwMywxMyBAQCB2b2lkIGFsc2FfcmVnaXN0ZXJfb3V0cHV0X2NhbGxiYWNrKHN0cnVj dCBhbHNhICphbHNhLA0KPiA+ICBpbnQgYWxzYV9ydW4oc3RydWN0IGFsc2EgKmFsc2EsIGludCBk dXJhdGlvbl9tcykNCj4gPiAgew0KPiA+ICAJc25kX3BjbV90ICpoYW5kbGU7DQo+ID4gLQlzaG9y dCAqb3V0cHV0X2J1ZmZlciA9IE5VTEw7DQo+ID4gKwljaGFyICpvdXRwdXRfYnVmZmVyID0gTlVM TDsNCj4gDQo+IFdoeSBub3Qgdm9pZCo/DQoNCkJlbG93IGluIHRoZSBzbmRfcGNtX3dyaXRlaSBj YWxsLCB3ZSBuZWVkIHRvIGFkZCBhbiBvZmZzZXQgdG8gdGhpcw0KYWRkcmVzcy4gU2luY2UgaXQn cyBub3QgcG9zc2libGUgdG8gdXNlIHRoZSBhcnJheSBzeW50YXggb24gdm9pZCAqIEkNCnVzZWQg Y2hhciAqLiBUaGF0IHdheSBvdXRwdXRfYnVmZmVyW2ldIGlzIHRoZSBpLXRoIGJ5dGUgb2YNCm91 dHB1dF9idWZmZXIuDQoNCihOb3RlIHRoYXQgZG9pbmcgcG9pbnRlciBhcml0aG1ldGljIG9uIHZv aWQgKiBpcyB1bmRlZmluZWQgYmVoYXZpb3VyLikNCg0KPiA+ICAJaW50IG91dHB1dF9saW1pdDsN Cj4gPiAgCWludCBvdXRwdXRfdG90YWwgPSAwOw0KPiA+ICAJaW50IG91dHB1dF9jb3VudHNbYWxz YS0+b3V0cHV0X2hhbmRsZXNfY291bnRdOw0KPiA+ICAJYm9vbCBvdXRwdXRfcmVhZHkgPSBmYWxz ZTsNCj4gPiAgCWludCBvdXRwdXRfY2hhbm5lbHM7DQo+ID4gKwlpbnQgYnl0ZXNfcGVyX3NhbXBs ZTsNCj4gPiAgCWludCBvdXRwdXRfdHJpZ2dlcjsNCj4gPiAgCWJvb2wgcmVhY2hlZDsNCj4gPiAg CWludCBpbmRleDsNCj4gPiBAQCAtNDE4LDkgKzQyMCwxMCBAQCBpbnQgYWxzYV9ydW4oc3RydWN0 IGFsc2EgKmFsc2EsIGludCBkdXJhdGlvbl9tcykNCj4gPiAgDQo+ID4gIAlvdXRwdXRfbGltaXQg PSBhbHNhLT5vdXRwdXRfc2FtcGxpbmdfcmF0ZSAqIGR1cmF0aW9uX21zIC8gMTAwMDsNCj4gPiAg CW91dHB1dF9jaGFubmVscyA9IGFsc2EtPm91dHB1dF9jaGFubmVsczsNCj4gPiArCWJ5dGVzX3Bl cl9zYW1wbGUgPSBzbmRfcGNtX2Zvcm1hdF9waHlzaWNhbF93aWR0aChhbHNhLT5vdXRwdXRfZm9y bWF0KSAvIDg7DQo+ID4gIAlvdXRwdXRfdHJpZ2dlciA9IGFsc2EtPm91dHB1dF9zYW1wbGVzX3Ry aWdnZXI7DQo+ID4gLQlvdXRwdXRfYnVmZmVyID0gbWFsbG9jKHNpemVvZihzaG9ydCkgKiBvdXRw dXRfY2hhbm5lbHMgKg0KPiA+IC0JCQkgICAgICAgb3V0cHV0X3RyaWdnZXIpOw0KPiA+ICsJb3V0 cHV0X2J1ZmZlciA9IG1hbGxvYyhvdXRwdXRfY2hhbm5lbHMgKiBvdXRwdXRfdHJpZ2dlciAqDQo+ ID4gKwkJCSAgICAgICBieXRlc19wZXJfc2FtcGxlKTsNCj4gPiAgDQo+ID4gIAlkbyB7DQo+ID4g IAkJcmVhY2hlZCA9IHRydWU7DQo+ID4gQEAgLTQ1NCw3ICs0NTcsNyBAQCBpbnQgYWxzYV9ydW4o c3RydWN0IGFsc2EgKmFsc2EsIGludCBkdXJhdGlvbl9tcykNCj4gPiAgCQkJCQljb3VudCA9IGF2 YWlsIDwgY291bnQgPyBhdmFpbCA6IGNvdW50Ow0KPiA+ICANCj4gPiAgCQkJCQlyZXQgPSBzbmRf cGNtX3dyaXRlaShoYW5kbGUsDQo+ID4gLQkJCQkJCQkgICAgICZvdXRwdXRfYnVmZmVyW2luZGV4 XSwNCj4gPiArCQkJCQkJCSAgICAgJm91dHB1dF9idWZmZXJbaW5kZXggKiBieXRlc19wZXJfc2Ft cGxlXSwNCj4gPiAgCQkJCQkJCSAgICAgY291bnQpOw0KPiA+ICAJCQkJCWlmIChyZXQgPCAwKSB7 DQo+ID4gIAkJCQkJCXJldCA9IHNuZF9wY21fcmVjb3ZlcihoYW5kbGUsDQo+ID4gZGlmZiAtLWdp dCBhL2xpYi9pZ3RfYWxzYS5oIGIvbGliL2lndF9hbHNhLmgNCj4gPiBpbmRleCBhMTA5ODVmZjc3 N2YuLjQ2YjM1NjhkMjZmZCAxMDA2NDQNCj4gPiAtLS0gYS9saWIvaWd0X2Fsc2EuaA0KPiA+ICsr KyBiL2xpYi9pZ3RfYWxzYS5oDQo+ID4gQEAgLTI5LDYgKzI5LDcgQEANCj4gPiAgDQo+ID4gICNp bmNsdWRlICJjb25maWcuaCINCj4gPiAgDQo+ID4gKyNpbmNsdWRlIDxhbHNhL2Fzb3VuZGxpYi5o Pg0KPiA+ICAjaW5jbHVkZSA8c3RkYm9vbC5oPg0KPiA+ICANCj4gPiAgc3RydWN0IGFsc2E7DQo+ ID4gQEAgLTM5LDEwICs0MCwxMCBAQCBpbnQgYWxzYV9vcGVuX291dHB1dChzdHJ1Y3QgYWxzYSAq YWxzYSwgY29uc3QgY2hhciAqZGV2aWNlX25hbWUpOw0KPiA+ICB2b2lkIGFsc2FfY2xvc2Vfb3V0 cHV0KHN0cnVjdCBhbHNhICphbHNhKTsNCj4gPiAgYm9vbCBhbHNhX3Rlc3Rfb3V0cHV0X2NvbmZp Z3VyYXRpb24oc3RydWN0IGFsc2EgKmFsc2EsIGludCBjaGFubmVscywNCj4gPiAgCQkJCSAgICBp bnQgc2FtcGxpbmdfcmF0ZSk7DQo+ID4gLXZvaWQgYWxzYV9jb25maWd1cmVfb3V0cHV0KHN0cnVj dCBhbHNhICphbHNhLCBpbnQgY2hhbm5lbHMsDQo+ID4gLQkJCSAgIGludCBzYW1wbGluZ19yYXRl KTsNCj4gPiArdm9pZCBhbHNhX2NvbmZpZ3VyZV9vdXRwdXQoc3RydWN0IGFsc2EgKmFsc2EsIHNu ZF9wY21fZm9ybWF0X3QgZm10LA0KPiA+ICsJCQkgICBpbnQgY2hhbm5lbHMsIGludCBzYW1wbGlu Z19yYXRlKTsNCj4gPiAgdm9pZCBhbHNhX3JlZ2lzdGVyX291dHB1dF9jYWxsYmFjayhzdHJ1Y3Qg YWxzYSAqYWxzYSwNCj4gPiAtCQkJCSAgIGludCAoKmNhbGxiYWNrKSh2b2lkICpkYXRhLCBzaG9y dCAqYnVmZmVyLCBpbnQgc2FtcGxlcyksDQo+ID4gKwkJCQkgICBpbnQgKCpjYWxsYmFjaykodm9p ZCAqZGF0YSwgdm9pZCAqYnVmZmVyLCBpbnQgc2FtcGxlcyksDQo+ID4gIAkJCQkgICB2b2lkICpj YWxsYmFja19kYXRhLCBpbnQgc2FtcGxlc190cmlnZ2VyKTsNCj4gPiAgaW50IGFsc2FfcnVuKHN0 cnVjdCBhbHNhICphbHNhLCBpbnQgZHVyYXRpb25fbXMpOw0KPiA+ICANCj4gPiBkaWZmIC0tZ2l0 IGEvdGVzdHMva21zX2NoYW1lbGl1bS5jIGIvdGVzdHMva21zX2NoYW1lbGl1bS5jDQo+ID4gaW5k ZXggYzhiNmIyMmQ3YjRhLi4yYjQ2NTU2NTQxOGQgMTAwNjQ0DQo+ID4gLS0tIGEvdGVzdHMva21z X2NoYW1lbGl1bS5jDQo+ID4gKysrIGIvdGVzdHMva21zX2NoYW1lbGl1bS5jDQo+ID4gQEAgLTgw MSwxMSArODAxLDExIEBAIHN0cnVjdCBhdWRpb19zdGF0ZSB7DQo+ID4gIH07DQo+ID4gIA0KPiA+ ICBzdGF0aWMgaW50DQo+ID4gLWF1ZGlvX291dHB1dF9jYWxsYmFjayh2b2lkICpkYXRhLCBzaG9y dCAqYnVmZmVyLCBpbnQgZnJhbWVzKQ0KPiA+ICthdWRpb19vdXRwdXRfY2FsbGJhY2sodm9pZCAq ZGF0YSwgdm9pZCAqYnVmZmVyLCBpbnQgc2FtcGxlcykNCj4gPiAgew0KPiA+ICAJc3RydWN0IGF1 ZGlvX3N0YXRlICpzdGF0ZSA9IGRhdGE7DQo+ID4gIA0KPiA+IC0JYXVkaW9fc2lnbmFsX2ZpbGxf czE2X2xlKHN0YXRlLT5zaWduYWwsIGJ1ZmZlciwgZnJhbWVzKTsNCj4gPiArCWF1ZGlvX3NpZ25h bF9maWxsX3MxNl9sZShzdGF0ZS0+c2lnbmFsLCBidWZmZXIsIHNhbXBsZXMpOw0KPiA+ICANCj4g PiAgCXJldHVybiBzdGF0ZS0+cnVuID8gMCA6IC0xOw0KPiA+ICB9DQo+ID4gQEAgLTg0Myw3ICs4 NDMsOCBAQCBkb190ZXN0X2Rpc3BsYXlfYXVkaW8oZGF0YV90ICpkYXRhLCBzdHJ1Y3QgY2hhbWVs aXVtX3BvcnQgKnBvcnQsDQo+ID4gIA0KPiA+ICAJaWd0X2RlYnVnKCJUZXN0aW5nIHdpdGggcGxh eWJhY2sgc2FtcGxpbmcgcmF0ZSAlZCBIeiBhbmQgJWQgY2hhbm5lbHNcbiIsDQo+ID4gIAkJICBw bGF5YmFja19yYXRlLCBwbGF5YmFja19jaGFubmVscyk7DQo+ID4gLQlhbHNhX2NvbmZpZ3VyZV9v dXRwdXQoYWxzYSwgcGxheWJhY2tfY2hhbm5lbHMsIHBsYXliYWNrX3JhdGUpOw0KPiA+ICsJYWxz YV9jb25maWd1cmVfb3V0cHV0KGFsc2EsIFNORF9QQ01fRk9STUFUX1MxNl9MRSwNCj4gPiArCQkJ ICAgICAgcGxheWJhY2tfY2hhbm5lbHMsIHBsYXliYWNrX3JhdGUpOw0KPiA+ICANCj4gPiAgCWNo YW1lbGl1bV9zdGFydF9jYXB0dXJpbmdfYXVkaW8oZGF0YS0+Y2hhbWVsaXVtLCBwb3J0LCBmYWxz ZSk7DQo+ID4gIA0KPiA+IA0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2