Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Gupta, Nidhi1" <nidhi1.gupta@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
	"igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>
Cc: "Latvala, Petri" <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] Check for available outputs
Date: Fri, 4 Dec 2020 08:15:03 +0000	[thread overview]
Message-ID: <899d5b123777447dae328207e2d35f05@intel.com> (raw)
In-Reply-To: <160690139620.2037.12501279123485164291@build.alporthouse.com>

Thanks for the review Chris, what I am trying to do is to execute 
subtest only on the available output not on all, as all the tests which 
I grouped together are dual display tests so I merged them together , 
can you suggest some way to achieve the same if not using dynamic subtest?


-----Original Message-----
From: Chris Wilson <chris@chris-wilson.co.uk> 
Sent: Wednesday, December 2, 2020 3:00 PM
To: igt-dev@lists.freedesktop.org; Gupta, Nidhi1 <nidhi1.gupta@intel.com>
Cc: Gupta, Nidhi1 <nidhi1.gupta@intel.com>; Latvala, Petri <petri.latvala@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] Check for available outputs

Quoting nidhi1.gupta@intel.com (2020-12-02 09:17:47)
> From: Nidhi Gupta <nidhi1.gupta@intel.com>
> 
> In kms_cursor_legacy will test all the pipes defined in IGT which is 6 
> weather the output is available or not.Later it has to be analysed and 
> discard it as valid skip.To save this time updated in test to first 
> check the available outputs and then execute the test.

There needs to be much strongly guidelines on when to use dynamic.
Subtests by another name is not ideal.

These are definitely not all the same test, labelling them as minor variations of the same theme is ridiculous.

You are trying to work around a "problem" caused by another tool.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2020-12-04  8:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02  9:17 [igt-dev] [PATCH i-g-t] Check for available outputs nidhi1.gupta
2020-12-02  9:29 ` Chris Wilson
2020-12-04  8:15   ` Gupta, Nidhi1 [this message]
2020-12-04 10:17     ` Chris Wilson
2020-12-02 10:00 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=899d5b123777447dae328207e2d35f05@intel.com \
    --to=nidhi1.gupta@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=petri.latvala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox