From: Martin Peres <martin.peres@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, intel-gfx@lists.freedesktop.org
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] i915/gem_eio: Trim kms workload
Date: Fri, 21 Feb 2020 09:20:43 +0200 [thread overview]
Message-ID: <8a1d8cc5-dbb4-88f4-06d9-ccaa79c41f0c@linux.intel.com> (raw)
In-Reply-To: <20200220165301.1996742-1-chris@chris-wilson.co.uk>
On 2020-02-20 18:53, Chris Wilson wrote:
> We don't need to try reset-stress on every engine with the display, just
> once is enough to stress any interlinkage.
If you say so :)
>
> This should reduce the runtime to 10s.
That would be appreciated!
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Martin Peres <martin.peres@linux.intel.com>
The only difference between the previous behaviour and the new one
introduced by the patch is that reset_stress() is called for only the
default exec engine as opposed to all of them previously. So, the patch is:
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
> ---
> tests/i915/gem_eio.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/tests/i915/gem_eio.c b/tests/i915/gem_eio.c
> index 0fe51efeb..1ec609410 100644
> --- a/tests/i915/gem_eio.c
> +++ b/tests/i915/gem_eio.c
> @@ -898,8 +898,14 @@ static void test_kms(int i915, igt_display_t *dpy)
>
> test_inflight(i915, 0);
> if (gem_has_contexts(i915)) {
> - test_reset_stress(i915, 0);
> - test_reset_stress(i915, TEST_WEDGE);
> + uint32_t ctx = context_create_safe(i915);
> +
> + reset_stress(i915, ctx,
> + "default", I915_EXEC_DEFAULT, 0);
> + reset_stress(i915, ctx,
> + "default", I915_EXEC_DEFAULT, TEST_WEDGE);
> +
> + gem_context_destroy(i915, ctx);
> }
>
> *shared = 1;
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2020-02-21 7:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 16:53 [igt-dev] [PATCH i-g-t] i915/gem_eio: Trim kms workload Chris Wilson
2020-02-20 17:43 ` [igt-dev] ✗ Fi.CI.BAT: failure for " Patchwork
2020-02-21 7:20 ` Martin Peres [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8a1d8cc5-dbb4-88f4-06d9-ccaa79c41f0c@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox