Igt-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>
To: Jeevan B <jeevan.b@intel.com>, <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t] tests/kms_display_modes: Skip mirrored pipe combinations
Date: Wed, 8 Jul 2026 10:19:49 +0530	[thread overview]
Message-ID: <8a286006-268c-4d98-9b24-00d9d281be30@intel.com> (raw)
In-Reply-To: <20260707041113.3997991-1-jeevan.b@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1258 bytes --]

Hi Jeevan,

On 7/7/2026 9:41 AM, Jeevan B wrote:
> Use a canonical pipe ordering in extended-mode-basic so each pipe pair
> is tested only once. This removes mirrored combinations (A-B and B-A)
> that provide duplicate coverage.
>
> Reducing these redundant combinations lowers the total number of dynamic
> subtests, helping prevent incomplete test execution in CI while
> preserving coverage of all pipe and output pairings.
>
> v2: Skip mirrored pipe pairs, but keep both directions for SST<->MST
>      combos.
>
> Signed-off-by: Jeevan B<jeevan.b@intel.com>
> ---
>   tests/kms_display_modes.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/tests/kms_display_modes.c b/tests/kms_display_modes.c
> index d8aae4256..c1876aa05 100644
> --- a/tests/kms_display_modes.c
> +++ b/tests/kms_display_modes.c
> @@ -193,6 +193,11 @@ static void run_extendedmode_test(data_t *data) {
>   			if (output1 == output2)
>   				continue;
>   
> +			if (crtc1->pipe > crtc2->pipe &&
> +			    igt_check_output_is_dp_mst(output1) ==
> +			    igt_check_output_is_dp_mst(output2))
> +				continue;
> +
>   			igt_display_reset(display);
>   
>   			igt_output_set_crtc(output1, crtc1);

LGTM,

Reviewed-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>

[-- Attachment #2: Type: text/html, Size: 1932 bytes --]

  parent reply	other threads:[~2026-07-08  4:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-07  4:11 [PATCH i-g-t] tests/kms_display_modes: Skip mirrored pipe combinations Jeevan B
2026-07-07  9:35 ` ✓ Xe.CI.BAT: success for tests/kms_display_modes: Skip mirrored pipe combinations (rev2) Patchwork
2026-07-07  9:39 ` ✓ i915.CI.BAT: " Patchwork
2026-07-07 11:25 ` ✓ Xe.CI.FULL: " Patchwork
2026-07-07 22:39 ` ✓ i915.CI.Full: " Patchwork
2026-07-08  4:49 ` Naladala, Ramanaidu [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-07-06  5:08 [PATCH i-g-t] tests/kms_display_modes: Skip mirrored pipe combinations Jeevan B
2026-07-06 13:52 ` Naladala, Ramanaidu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a286006-268c-4d98-9b24-00d9d281be30@intel.com \
    --to=ramanaidu.naladala@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jeevan.b@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox