Re: [PATCH] tests/intel/kms_pm_rpm: Update cursor_fb3 framebuffer creation format

["Sharma, Swati2" <swati2.sharma@intel.com>]

Hi Rodrigo,

On 25-11-2024 11:52 pm, Rodrigo Vivi wrote:
> On Mon, Nov 25, 2024 at 10:40:28PM +0530, Jeevan B wrote:
>> Updated cursor_fb3 framebuffer creation in the cursor subtest function
>> to use linear tiling instead of x-tile. As x-tile is no longer supported
>> on latest platforms.
> Shouldn't we then add a new format without removing the old ones?
> Otherwise it looks like you are removing coverage on old platforms.
Is there any specific reason why x tiling was used initially? Any idea?
Isn't linear tiling common across all platforms?
>> Signed-off-by: Jeevan B <jeevan.b@intel.com>
>> ---
>>   tests/intel/kms_pm_rpm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tests/intel/kms_pm_rpm.c b/tests/intel/kms_pm_rpm.c
>> index 990c50915..aeeaf69f7 100644
>> --- a/tests/intel/kms_pm_rpm.c
>> +++ b/tests/intel/kms_pm_rpm.c
>> @@ -1199,7 +1199,7 @@ static void cursor_subtest(bool dpms)
>>   	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_ARGB8888,
>>   		      DRM_FORMAT_MOD_LINEAR, &cursor_fb2);
>>   	igt_create_fb(drm_fd, 64, 64, DRM_FORMAT_XRGB8888,
>> -		      I915_FORMAT_MOD_X_TILED, &cursor_fb3);
>> +		      DRM_FORMAT_MOD_LINEAR, &cursor_fb3);
>>   
>>   	fill_igt_fb(&cursor_fb1, 0xFF00FFFF);
>>   	fill_igt_fb(&cursor_fb2, 0xFF00FF00);
>> -- 
>> 2.25.1
>>