From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B6FC899FF for ; Wed, 31 Jul 2019 08:25:15 +0000 (UTC) From: "Ser, Simon" Date: Wed, 31 Jul 2019 08:25:12 +0000 Message-ID: <8b71e20f73c286103d6379a00c2abb3d74135082.camel@intel.com> References: <20190717181055.581-1-madhumitha.tolakanahalli.pradeep@intel.com> <6a7512c12f04cb23827f6d19536409b2359a7eb7.camel@intel.com> <20190730192400.GB2736@intel.com> In-Reply-To: <20190730192400.GB2736@intel.com> Content-Language: en-US Content-ID: MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH] lib/igt_kms.c igt_kms.h: tile property parser List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: "Navare, Manasi D" Cc: "igt-dev@lists.freedesktop.org" , "Latvala, Petri" List-ID: T24gVHVlLCAyMDE5LTA3LTMwIGF0IDEyOjI0IC0wNzAwLCBNYW5hc2kgTmF2YXJlIHdyb3RlOg0K PiBPbiBXZWQsIEp1bCAxNywgMjAxOSBhdCAxMToyNDozM1BNIC0wNzAwLCBTZXIsIFNpbW9uIHdy b3RlOg0KPiA+IEhpLA0KPiA+IA0KPiA+IEhlcmUgYXJlIGEgZmV3IGNvbW1lbnRzLg0KPiA+IA0K PiA+IE9uIFdlZCwgMjAxOS0wNy0xNyBhdCAxMToxMCAtMDcwMCwgTWFkaHVtaXRoYSBUb2xha2Fu YWhhbGxpIFByYWRlZXAgd3JvdGU6DQo+ID4gPiBUaGUgdGlsZSBwcm9wZXJ0eSBwYXJzZXIgcGFy c2VzIHRoZSBjb25uZWN0b3IgdGlsZSBwcm9wZXJ0eSBvYnRhaW5lZA0KPiA+ID4gZnJvbSBjb25u ZWN0b3IncyBEaXNwbGF5IElEIGJsb2NrIGFuZCBzZXQgcGVyIGNvbm5lY3Rvci4NCj4gPiA+IA0K PiA+ID4gQ2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+DQo+ID4g PiBDYzogUGV0cmkgTGF0dmFsYSA8cGV0cmkubGF0dmFsYUBpbnRlbC5jb20+DQo+ID4gPiBTaWdu ZWQtb2ZmLWJ5OiBNYWRodW1pdGhhIFRvbGFrYW5haGFsbGkgUHJhZGVlcCA8bWFkaHVtaXRoYS50 b2xha2FuYWhhbGxpLnByYWRlZXBAaW50ZWwuY29tPg0KPiA+ID4gLS0tDQo+ID4gPiAgbGliL2ln dF9rbXMuYyB8IDI2ICsrKysrKysrKysrKysrKysrKysrKysrKysrDQo+ID4gPiAgbGliL2lndF9r bXMuaCB8IDExICsrKysrKysrKysrDQo+ID4gPiAgMiBmaWxlcyBjaGFuZ2VkLCAzNyBpbnNlcnRp b25zKCspDQo+ID4gPiANCj4gPiA+IGRpZmYgLS1naXQgYS9saWIvaWd0X2ttcy5jIGIvbGliL2ln dF9rbXMuYw0KPiA+ID4gaW5kZXggMTc1ZTcxYzMuLjg0NjMxNGRlIDEwMDY0NA0KPiA+ID4gLS0t IGEvbGliL2lndF9rbXMuYw0KPiA+ID4gKysrIGIvbGliL2lndF9rbXMuYw0KPiA+ID4gQEAgLTQ1 MTEsMyArNDUxMSwyOSBAQCBib29sIGlndF9kaXNwbGF5X2hhc19mb3JtYXRfbW9kKGlndF9kaXNw bGF5X3QgKmRpc3BsYXksIHVpbnQzMl90IGZvcm1hdCwNCj4gPiA+ICANCj4gPiA+ICAJcmV0dXJu IGZhbHNlOw0KPiA+ID4gIH0NCj4gPiA+ICsNCj4gPiA+ICsvKioNCj4gPiA+ICsgKiBpZ3RfcGFy c2VfY29ubmVjdG9yX3RpbGVfYmxvYjoNCj4gPiA+ICsgKiBAYmxvYjogcG9pbnRlciB0byB0aGUg Y29ubmVjdG9yJ3MgdGlsZSBwcm9wZXJ0aWVzDQo+ID4gPiArICogQHRpbGU6IHBvaW50ZXIgdG8g dGlsZSBzdHJ1Y3R1cmUgdGhhdCBpcyBwb3B1bGF0ZWQgYnkgdGhlIGZ1bmN0aW9uDQo+ID4gPiAr ICoNCj4gPiA+ICsgKiBQYXJzZXMgdGhlIGNvbm5lY3RvciB0aWxlIGJsb2IgdG8gZXh0cmFjdCB0 aGUgdGlsZSBpbmZvcm1hdGlvbg0KPiA+ID4gKyAqDQo+ID4gPiArICovDQo+ID4gPiArDQo+ID4g PiArdm9pZCBpZ3RfcGFyc2VfY29ubmVjdG9yX3RpbGVfYmxvYihkcm1Nb2RlUHJvcGVydHlCbG9i UHRyIGJsb2IsDQo+ID4gPiArCQkJCWlndF90aWxlX2luZm9fdCAqIHRpbGUpDQo+ID4gDQo+ID4g U3R5bGU6IGFsaWduIHdpdGggYXMgbWFueSB0YWJzIGFzIHBvc3NpYmxlLCB0aGVuIGZpbGwgdGhl IHJlc3Qgd2l0aA0KPiA+IHNwYWNlcy4NCj4gPiANCj4gPiA+ICt7DQo+ID4gPiArCWNoYXIgKiBi bG9iX2RhdGEgPSBibG9iLT5kYXRhOw0KPiA+IA0KPiA+IFN0eWxlOiBubyBzcGFjZSBhZnRlciBz dGFyLg0KPiA+IA0KPiA+ICAgICBjaGFyICp0aGluZyA9IHN0dWZmOw0KPiA+IA0KPiA+IEFwcGxp ZXMgdG8gdGhlIHdob2xlIHBhdGNoLg0KPiA+IA0KPiA+ID4gKwlpZihibG9iKSB7DQo+ID4gDQo+ ID4gU3R5bGU6IHNwYWNlIGFmdGVyIGlmIGtleXdvcmQuDQo+ID4gDQo+ID4gPiArCQl0aWxlLT50 aWxlX2dyb3VwX2lkID0gYXRvaShzdHJ0b2soYmxvYl9kYXRhLCAiOiIpKTsNCj4gPiANCj4gPiBU aGlzIHNlZ2ZhdWx0cyBpZiB0aGUgZmllbGQgZG9lc24ndCBleGlzdC4gSXQgd291bGQgYmUgbmlj ZXIgdG8NCj4gPiBpZ3RfYXNzZXJ0IHRoYXQgc3RydG9rIGRvZXNuJ3QgcmV0dXJuIE5VTEwuIE1h eWJlIHdpdGggYSB3cmFwcGVyDQo+ID4gZnVuY3Rpb24/IGUuZy4NCj4gPiANCj4gPiAgICAgc3Rh dGljIGludCBwYXJzZV9uZXh0X3RpbGVfZmllbGQoY2hhciAqZGF0YSkNCj4gPiANCj4gPiBBbHNv IHRoaXMgZG9lc24ndCBjaGVjayBmb3IgaW50ZWdlciBvdmVyZmxvd3MsIGJ1dCBub3Qgc3VyZSBp dCdzIHdvcnRoDQo+ID4gdGhlIGhhc3NsZS4NCj4gPiANCj4gPiA+ICsJCXRpbGUtPnRpbGVfaXNf c2luZ2xlX21vbml0b3IgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUt Pm51bV9oX3RpbGUgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPm51 bV92X3RpbGUgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPnRpbGVf aF9sb2MgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPnRpbGVfdl9s b2MgPSBhdG9pKHN0cnRvayhOVUxMLCAiOiIpKTsNCj4gPiA+ICsJCXRpbGUtPnRpbGVfaF9zaXpl ID0gYXRvaShzdHJ0b2soTlVMTCwgIjoiKSk7DQo+ID4gPiArCQl0aWxlLT50aWxlX3Zfc2l6ZSA9 IGF0b2koc3RydG9rKE5VTEwsICI6IikpOw0KPiA+ID4gKwl9DQo+ID4gPiArfQ0KPiA+ID4gZGlm ZiAtLWdpdCBhL2xpYi9pZ3Rfa21zLmggYi9saWIvaWd0X2ttcy5oDQo+ID4gPiBpbmRleCAwNDg2 NzM3Yi4uMDg0ODM1MDUgMTAwNjQ0DQo+ID4gPiAtLS0gYS9saWIvaWd0X2ttcy5oDQo+ID4gPiAr KysgYi9saWIvaWd0X2ttcy5oDQo+ID4gPiBAQCAtMzg3LDYgKzM4NywxNCBAQCBzdHJ1Y3QgaWd0 X2Rpc3BsYXkgew0KPiA+ID4gIAlpbnQgZm9ybWF0X21vZF9jb3VudDsNCj4gPiA+ICB9Ow0KPiA+ ID4gIA0KPiA+ID4gK3R5cGVkZWYgc3RydWN0IHsNCj4gPiA+ICsJaW50IHRpbGVfZ3JvdXBfaWQ7 DQo+ID4gPiArCWJvb2wgdGlsZV9pc19zaW5nbGVfbW9uaXRvcjsNCj4gPiA+ICsJdWludDhfdCBu dW1faF90aWxlLCBudW1fdl90aWxlOw0KPiA+ID4gKwl1aW50OF90IHRpbGVfaF9sb2MsIHRpbGVf dl9sb2M7DQo+ID4gPiArCXVpbnQxNl90IHRpbGVfaF9zaXplLCB0aWxlX3Zfc2l6ZTsNCj4gPiAN Cj4gPiBJIHdvdWxkbid0IHJlcGVhdCB0aGUgdGlsZV8gcHJlZml4IGZvciBhbGwgb2YgdGhlc2Ug ZmllbGRzLCBpdCdzDQo+ID4gYWxyZWFkeSBjbGVhciB0aGF0IGl0J3MgYWJvdXQgdGhlIHRpbGUg ZnJvbSB0aGUgdHlwZSBuYW1lLg0KPiANCj4gVGhlIGlkZWEgb2YgdXNpbmcgdGlsZV8gcHJlZml4 IGlzIHNvIHRoYXQgaXQgYWxpZ25zIHdpdGggdGhlIHRpbGUgZmllbGRzIGluIHRoZQ0KPiBrZXJu ZWwgYW5kIHRoZXNlIGFyZSB0aGUgZXhhY3QgbmFtZXMgdGhhdCBnZXQgcHJpbnRlZCBpbiB0aGUg ZG1lc2cgc28gbWFrZXMNCj4gaXQgbW9yZSBpbnR1aXRpdmUgaWYgd2Ugc3RpY2sgdG8gdGhlc2Ug bmFtZXMuDQoNCkkgc2VlLCBtYWtlcyBwZXJmZWN0IHNlbnNlLg0KDQo+IE1hbmFzaQ0KPiANCj4g PiA+ICt9IGlndF90aWxlX2luZm9fdDsNCj4gPiANCj4gPiBJJ20gcGVyc29uYWxseSBub3QgYSBm YW4gb2YgdHlwZWRlZnMsIGJ1dCBpdCBzZWVtcyBsaWtlIHRoZSByZXN0IG9mIElHVA0KPiA+IGRv ZXNuJ3QgY2FyZSwgc28gaXQncyBwcm9iYWJseSBmaW5lLg0KPiA+IA0KPiA+ID4gIHZvaWQgaWd0 X2Rpc3BsYXlfcmVxdWlyZShpZ3RfZGlzcGxheV90ICpkaXNwbGF5LCBpbnQgZHJtX2ZkKTsNCj4g PiA+ICB2b2lkIGlndF9kaXNwbGF5X2ZpbmkoaWd0X2Rpc3BsYXlfdCAqZGlzcGxheSk7DQo+ID4g PiAgdm9pZCBpZ3RfZGlzcGxheV9yZXNldChpZ3RfZGlzcGxheV90ICpkaXNwbGF5KTsNCj4gPiA+ IEBAIC04MzUsNCArODQzLDcgQEAgc3RhdGljIGlubGluZSBib29sIGlndF92YmxhbmtfYmVmb3Jl KHVpbnQzMl90IGEsIHVpbnQzMl90IGIpDQo+ID4gPiAgCXJldHVybiBpZ3RfdmJsYW5rX2FmdGVy KGIsIGEpOw0KPiA+ID4gIH0NCj4gPiA+ICANCj4gPiA+ICt2b2lkIGlndF9wYXJzZV9jb25uZWN0 b3JfdGlsZV9ibG9iKGRybU1vZGVQcm9wZXJ0eUJsb2JQdHIgYmxvYiwNCj4gPiA+ICsJCQlpZ3Rf dGlsZV9pbmZvX3QgKiB0aWxlKTsNCj4gPiA+ICsNCj4gPiA+ICAjZW5kaWYgLyogX19JR1RfS01T X0hfXyAqLw0KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K aWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pZ3QtZGV2