Re: [PATCH i-g-t v2] kms/feature_discovery: Add VRR capability subtest per output

["Naladala, Ramanaidu" <Ramanaidu.naladala@intel.com>]

Hi Swati,

Yes it is wrongly coded. i will fix this in next review. Thank you for 
the review.

On 3/26/2026 12:42 PM, Sharma, Swati2 wrote:
> Hi Ramanaidu
>
> On 20-03-2026 12:13 pm, Naladala Ramanaidu wrote:
>> Add a dynamic "vrr" subtest that checks vrr capability on each
>> connected output, skipping if the driver or output lacks VRR
>> support.
>>
>> v2: Address review comments. (Bilal, Sowmiya)
>>
>> Signed-off-by: Naladala Ramanaidu <ramanaidu.naladala@intel.com>
>> ---
>>   tests/kms_feature_discovery.c | 19 +++++++++++++++++++
>>   1 file changed, 19 insertions(+)
>>
>> diff --git a/tests/kms_feature_discovery.c 
>> b/tests/kms_feature_discovery.c
>> index 28ec89c55..7b197b848 100644
>> --- a/tests/kms_feature_discovery.c
>> +++ b/tests/kms_feature_discovery.c
>> @@ -60,6 +60,10 @@
>>    * Description: Make sure that we have eDP panel with PSR2 support.
>>    * Mega feature: PSR
>>    *
>> + * SUBTEST: vrr
>> + * Description: Make sure that we have VRR support on output.
>> + * Mega feature: Adaptive Sync
>> + *
>>    * SUBTEST: dp-mst
>>    * Description: Make sure that we have DP-MST configuration.
>>    *
>> @@ -157,6 +161,21 @@ int igt_main() {
>>               igt_require(psr_sink_support(fd, debugfs_fd, 
>> PSR_MODE_2, NULL));
>>           }
>>   +        igt_describe("Make sure that we have VRR support on 
>> output.");
>> +        igt_subtest_with_dynamic("vrr") {
>> +            igt_output_t *output;
>> +
>> +            igt_skip_on_f(!igt_output_has_prop(output, 
>> IGT_CONNECTOR_VRR_CAPABLE),
> o/p is uninitialized here.
>> +                      "Driver does not support VRR.\n");
> This doesn't look right. Can you check if we have some CAP reg to tell 
> driver's capability to support VRR.
>> +
>> +            for_each_connected_output(&display, output) {
>> +                igt_dynamic_f("%s", output->name)
>> +                    if (!igt_output_get_prop(output,
>> +                                 IGT_CONNECTOR_VRR_CAPABLE))
>> +                        igt_skip("VRR not supported on this 
>> output.\n");
>
> Instead of igt_skip we should have igt_require(). Please check how 
> other feature discovery tests are written.
>
> Follow same pattern.
>
>> +            }
>> +        }
>> +
>>           igt_describe("Make sure that we have DP-MST configuration.");
>>           igt_subtest("dp-mst") {
>>               struct kmstest_connector_config config;