From: Martin Peres <martin.peres@linux.intel.com>
To: Simon Ser <simon.ser@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t v7 0/8] tests/kms_chamelium: add dp-audio test
Date: Thu, 25 Apr 2019 13:00:02 +0300 [thread overview]
Message-ID: <8bf6ad32-b1e4-9df7-849d-427daa6e1641@linux.intel.com> (raw)
In-Reply-To: <20190423130459.31594-1-simon.ser@intel.com>
On 23/04/2019 16:04, Simon Ser wrote:
> Changes in v7: addressed Martin's comments
>
> Thanks for the detailed review! I've tried splitting some commits, let me know
> if more splitting is needed.
Thanks for the changes! The series is (excluding the HAX patch):
Reviewed-by: Martin Peres <martin.peres@linux.intel.com>
>
> Simon Ser (8):
> tests/kms_chamelium: add dp-audio test
> tests/kms_chamelium: capture audio data in real-time
> lib/igt_{alsa,audio}: improve logging
> lib/igt_alsa: use variables to improve readability
> tests/kms_chamelium: test we receive a signal from both audio channels
> tests/kms_chamelium: test audio channels are not mixed up
> tests/kms_chamelium: run audio test with multiple sampling rates
> HAX: add dp-audio test to fast-feedback
>
> docs/audio.txt | 45 --
> docs/chamelium.txt | 34 +-
> lib/igt.h | 1 +
> lib/igt_alsa.c | 83 +++-
> lib/igt_alsa.h | 1 +
> lib/igt_audio.c | 428 +++++++++++++------
> lib/igt_audio.h | 19 +-
> lib/igt_aux.c | 31 ++
> lib/igt_aux.h | 1 +
> lib/igt_chamelium.c | 161 ++++++++
> lib/igt_chamelium.h | 17 +
> lib/igt_chamelium_stream.c | 572 ++++++++++++++++++++++++++
> lib/igt_chamelium_stream.h | 50 +++
> lib/meson.build | 5 +-
> meson.build | 52 +--
> meson_options.txt | 6 -
> tests/audio.c | 193 ---------
> tests/intel-ci/fast-feedback.testlist | 1 +
> tests/kms_chamelium.c | 355 +++++++++++++++-
> tests/meson.build | 9 +-
> 20 files changed, 1614 insertions(+), 450 deletions(-)
> delete mode 100644 docs/audio.txt
> create mode 100644 lib/igt_chamelium_stream.c
> create mode 100644 lib/igt_chamelium_stream.h
> delete mode 100644 tests/audio.c
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2019-04-25 10:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-23 13:04 [igt-dev] [PATCH i-g-t v7 0/8] tests/kms_chamelium: add dp-audio test Simon Ser
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 1/8] " Simon Ser
2019-04-25 10:16 ` Petri Latvala
2019-04-25 11:37 ` Arkadiusz Hiler
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 2/8] tests/kms_chamelium: capture audio data in real-time Simon Ser
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 3/8] lib/igt_{alsa, audio}: improve logging Simon Ser
2019-04-25 9:53 ` Martin Peres
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 4/8] lib/igt_alsa: use variables to improve readability Simon Ser
2019-04-25 9:54 ` Martin Peres
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 5/8] tests/kms_chamelium: test we receive a signal from both audio channels Simon Ser
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 6/8] tests/kms_chamelium: test audio channels are not mixed up Simon Ser
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 7/8] tests/kms_chamelium: run audio test with multiple sampling rates Simon Ser
2019-04-23 13:04 ` [igt-dev] [PATCH i-g-t v7 8/8] HAX: add dp-audio test to fast-feedback Simon Ser
2019-04-23 15:29 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_chamelium: add dp-audio test (rev8) Patchwork
2019-04-23 18:33 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-04-25 10:00 ` Martin Peres [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8bf6ad32-b1e4-9df7-849d-427daa6e1641@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox