Re: [PATCH i-g-t 00/19] lib/kms: Clean up more of igt_kms API

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 25 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Adjust more of the igt_kms API to pass around igt_crtc_t*
> instead of enum pipe.
>
> I also wanted to have a better idea where in the tests we're
> still using igt_crtc_for_pipe(), so there's some cleanup
> around that. And then I added some new functions into igt_kms
> to replace some of those with more sensible things.
>
> This was supposed to be the last treewide series I'd do, but
> it naturally became too big. So I cut it roughly in the middle,
> and this is the first part. The second part is already done,
> but I'll hang on to it until this gets in.

Apart from a handful of comments inline, mostly about typos and cocci
being silly with whitespace or braces,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Good stuff. I think all of this underlines the importance setting a good
example in the codebase, because the worst stuff gets copied around
everywhere.


>
> Ville Syrjälä (19):
>   tests/kms_plane_multiple: Clean up n_planes stuff
>   tests/kms_async_flips: Remove redundant data.crtc_id
>   tests/kms_lease: Consolidate igt_crtc_for_pipe() calls
>   tests/kms: Consolidate igt_crtc_for_pipe() calls
>   lib/kms: Introduce igt_first_crtc_with_single_output()
>   tests/kms: Use igt_first_crtc_with_single_output()
>   lib/kms: Introduce and use igt_first_crtc()
>   tests/kms: Stop using igt_require_pipe()
>   lib/kms: Replace get_num_scalers() with igt_crtc_num_scalers()
>   lib/kms: Pass igt_crtc_t* to igt_max_bpc_constraint()
>   lib/kms: Introduce for_each_plane_on_crtc()
>   tests/kms: Use for_each_plane_on_crtc()
>   lib/kms: Nuke for_each_plane_on_pipe()
>   tests/kms: Switch to for_each_valid_output_on_crtc_local()
>   tests/kms: Replace igt_pipe_connector_valid() with
>     igt_crtc_connector_valid()
>   lib/kms: Intreoduce for_each_valid_output_on_crtc()
>   tests/intel/kms_frontbuffer_tracking: Use
>     for_each_valid_output_on_crtc()
>   tests/kms: Use for_each_valid_output_on_crtc()
>   lib/kms: Nuke for_each_valid_output_on_pipe()
>
>  lib/igt_kms.c                                 | 83 +++++++++++++------
>  lib/igt_kms.h                                 | 60 ++++----------
>  tests/amdgpu/amd_abm.c                        | 20 +++--
>  tests/amdgpu/amd_assr.c                       |  2 +-
>  tests/amdgpu/amd_bypass.c                     |  2 +-
>  tests/amdgpu/amd_color.c                      |  2 +-
>  tests/amdgpu/amd_cursor_overlay.c             |  2 +-
>  tests/amdgpu/amd_freesync_video_mode.c        |  2 +-
>  tests/amdgpu/amd_ilr.c                        |  2 +-
>  tests/amdgpu/amd_link_settings.c              |  2 +-
>  tests/amdgpu/amd_mall.c                       |  2 +-
>  tests/amdgpu/amd_max_bpc.c                    |  2 +-
>  tests/amdgpu/amd_mem_leak.c                   |  2 +-
>  tests/amdgpu/amd_mode_switch.c                |  5 +-
>  tests/amdgpu/amd_multidisplay_modeset.c       |  7 +-
>  tests/amdgpu/amd_odm.c                        |  6 +-
>  tests/amdgpu/amd_psr.c                        |  2 +-
>  tests/amdgpu/amd_replay.c                     |  2 +-
>  tests/chamelium/kms_chamelium_color.c         |  8 +-
>  .../kms_chamelium_sharpness_filter.c          |  6 +-
>  tests/intel/gem_eio.c                         | 11 ++-
>  tests/intel/gem_exec_reloc.c                  |  9 +-
>  tests/intel/gem_pxp.c                         |  4 +-
>  tests/intel/kms_big_fb.c                      |  3 +-
>  tests/intel/kms_busy.c                        |  3 +-
>  tests/intel/kms_ccs.c                         |  3 +-
>  tests/intel/kms_cdclk.c                       | 14 ++--
>  tests/intel/kms_dirtyfb.c                     |  4 +-
>  tests/intel/kms_dp_linktrain_fallback.c       |  2 +-
>  tests/intel/kms_fbc_dirty_rect.c              | 15 ++--
>  tests/intel/kms_flip_scaled_crc.c             |  8 +-
>  tests/intel/kms_frontbuffer_tracking.c        |  5 +-
>  tests/intel/kms_legacy_colorkey.c             |  5 +-
>  tests/intel/kms_pipe_stress.c                 | 30 ++++---
>  tests/intel/kms_pm_lpsp.c                     |  2 +-
>  tests/intel/xe_pxp.c                          |  6 +-
>  tests/kms_async_flips.c                       | 29 +++----
>  tests/kms_atomic.c                            |  3 +-
>  tests/kms_atomic_transition.c                 | 36 +++++---
>  tests/kms_bw.c                                |  5 +-
>  tests/kms_color.c                             | 11 +--
>  tests/kms_colorop.c                           |  3 +-
>  tests/kms_content_protection.c                |  2 +-
>  tests/kms_cursor_legacy.c                     |  6 +-
>  tests/kms_debugfs.c                           |  7 +-
>  tests/kms_display_modes.c                     | 11 +--
>  tests/kms_dither.c                            |  4 +-
>  tests/kms_feature_discovery.c                 |  4 +-
>  tests/kms_hdr.c                               |  6 +-
>  tests/kms_lease.c                             | 31 ++++---
>  tests/kms_plane.c                             |  9 +-
>  tests/kms_plane_alpha_blend.c                 |  8 +-
>  tests/kms_plane_lowres.c                      |  6 +-
>  tests/kms_plane_multiple.c                    | 25 +++---
>  tests/kms_plane_scaling.c                     | 78 +++++++++--------
>  tests/kms_properties.c                        | 16 ++--
>  tests/kms_rmfb.c                              |  6 +-
>  tests/kms_rotation_crc.c                      | 19 +++--
>  tests/kms_tiled_display.c                     |  2 +-
>  tools/amd_hdmi_compliance.c                   |  2 +-
>  60 files changed, 378 insertions(+), 294 deletions(-)

-- 
Jani Nikula, Intel