Re: [PATCH i-g-t] lib/intel_pat: skip UC compression when FlatCCS unavailable

["Wang, X" <x.wang@intel.com>]

On 5/11/2026 20:35, nishit.sharma@intel.com wrote:
> From: Nishit Sharma <nishit.sharma@intel.com>
>
> Use igt_require in place of igt_assert to avoid treating unsupported
> platform conditions as test errors in CI. Since UC compression is
> supported only on FlatCCS platforms, skip the test on platforms without
> FlatCCS.
>
> Signed-off-by: Nishit Sharma <nishit.sharma@intel.com>
> ---
>   lib/intel_pat.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/intel_pat.c b/lib/intel_pat.c
> index 2f35bb772..bcf31b4b2 100644
> --- a/lib/intel_pat.c
> +++ b/lib/intel_pat.c
> @@ -276,7 +276,7 @@ uint8_t intel_get_pat_idx_uc_comp(int fd)
>   	uint16_t dev_id = intel_get_drm_devid(fd);
>   
>   	igt_assert(intel_gen(dev_id) >= 20);
> -	igt_assert(HAS_FLATCCS(dev_id));
> +	igt_require_f(HAS_FLATCCS(dev_id), "FlatCCS not available on platform, skipping");
>   
As a basic library function, I don't think we should skip test cases here.
Theoretically, this function should return a value to the caller under 
all circumstances.
When on an unsupported platform, it's more logical to directly return 
`XE_PAT_IDX_INVALID`,
allowing the caller to decide whether to skip the test.

Thanks
Xin
>   	intel_get_pat_idx(fd, &pat);
>   	igt_assert_f(pat.uc_comp != XE_PAT_IDX_INVALID,