Re: [igt-dev] [PATCH i-g-t 1/2] tests/xe_pm : Add support to disable all crtc

[Riana Tauro <riana.tauro@intel.com>]

Hi Anshuman

On 6/27/2023 4:52 PM, Anshuman Gupta wrote:
> xe_pm d3 test requires to disable all crtc in order to enter
> to d3 state therefore, adding the support to disable all crtc.
> 
> Signed-off-by: Anshuman Gupta <anshuman.gupta@intel.com>
> ---
>   tests/xe/xe_pm.c | 20 ++++++++++++++++++++
>   1 file changed, 20 insertions(+)
> 
> diff --git a/tests/xe/xe_pm.c b/tests/xe/xe_pm.c
> index 23b8246ed..c71fce892 100644
> --- a/tests/xe/xe_pm.c
> +++ b/tests/xe/xe_pm.c
> @@ -34,6 +34,7 @@ typedef struct {
>   	int fd_xe;
>   	struct pci_device *pci_xe;
>   	struct pci_device *pci_root;
> +	igt_display_t display;
>   } device_t;
>   
>   /* runtime_usage is only available if kernel build CONFIG_PM_ADVANCED_DEBUG */
> @@ -150,6 +151,23 @@ static bool out_of_d3(device_t device, enum igt_acpi_d_state state)
>   	return true;
>   }
>   
> +static void disable_all_crtc(device_t *device)
> +{
> +	if (!drmModeGetResources(device->fd_xe))
> +		return;
> +
> +	igt_display_require(&device->display, device->fd_xe);
> +	igt_modeset_disable_all_outputs(&device->display);
> +}
> +
> +static void display_fini(device_t *device)
> +{
> +	if (!drmModeGetResources(device->fd_xe))
> +		return;
> +
> +	igt_display_fini(&device->display);
> +}
> +
>   /**
>    * SUBTEST: %s-basic
>    * Description: set GPU state to %arg[1] and test suspend/autoresume
> @@ -378,6 +396,7 @@ igt_main
>   
>   		get_d3cold_allowed(device.pci_xe, d3cold_allowed);
>   		igt_assert(igt_setup_runtime_pm(device.fd_xe));
> +		disable_all_crtc(&device);
Should this be added in setup_d3 instead of fixture? The suspend tests 
will also be executed with crtc disabled otherwise

Thanks
Riana


>   	}
>   
>   	for (const struct s_state *s = s_states; s->name; s++) {
> @@ -438,6 +457,7 @@ igt_main
>   	}
>   
>   	igt_fixture {
> +		display_fini(&device);
>   		set_d3cold_allowed(device.pci_xe, d3cold_allowed);
>   		igt_restore_runtime_pm();
>   		xe_device_put(device.fd_xe);