From: "Reddy Guddati, Santhosh" <santhosh.reddy.guddati@intel.com>
To: Pranay Samala <pranay.samala@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>, <sameer.lattannavar@intel.com>
Subject: Re: [PATCH i-g-t 2/2] tests/intel/kms_sharpness_filter: Detect and bypass joiner modes
Date: Tue, 3 Mar 2026 07:00:32 +0530 [thread overview]
Message-ID: <8e4bd54c-abbf-47c8-ab30-14a79d1fe536@intel.com> (raw)
In-Reply-To: <20260223093443.1797078-3-pranay.samala@intel.com>
Hi Pranay,
On 23-02-2026 15:04, Pranay Samala wrote:
> When the output configured to a joiner mode (Big Joiner or Ultra Joiner),
> switch to a non-joiner mode before running the sharpness filter test,
> since CASF is not supported on joiner configurations.
> This ensures the sharpness filter test runs on a single pipe configuration
> and avoid false failures.
>
> Signed-off-by: Pranay Samala <pranay.samala@intel.com>
> ---
> tests/intel/kms_sharpness_filter.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_sharpness_filter.c b/tests/intel/kms_sharpness_filter.c
> index eddfad6b9..e1a6be676 100644
> --- a/tests/intel/kms_sharpness_filter.c
> +++ b/tests/intel/kms_sharpness_filter.c
> @@ -440,7 +440,16 @@ run_sharpness_filter_test(data_t *data, enum test_type type)
> data->output = output;
> data->pipe_id = crtc->pipe;
> data->crtc = igt_crtc_for_pipe(display, data->pipe_id);
> - data->mode = igt_output_get_mode(data->output);
> +
> + if (is_joiner_mode(data->drm_fd, data->output)) {
If there is a known limitation with KMD that joiner and sharpness
concurrently do not work, please add FIXME.
> + data->mode = igt_get_non_joiner_mode(data->drm_fd, data->output);
> + igt_info("Executing on mode %dx%d@%d\n",
> + data->mode->hdisplay,
> + data->mode->vdisplay,
> + data->mode->vrefresh);
> + } else {
> + data->mode = igt_output_get_mode(data->output);
> + }
>
> if (!has_sharpness_filter(data->crtc)) {
> igt_info("%s: Doesn't support IGT_CRTC_SHARPNESS_STRENGTH.\n",
next prev parent reply other threads:[~2026-03-03 1:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-23 9:34 [PATCH i-g-t 0/2] Add helper to select non-joiner mode Pranay Samala
2026-02-23 9:34 ` [PATCH i-g-t 1/2] lib/igt_kms: Add helper to get " Pranay Samala
2026-02-26 12:09 ` Reddy Guddati, Santhosh
2026-02-23 9:34 ` [PATCH i-g-t 2/2] tests/intel/kms_sharpness_filter: Detect and bypass joiner modes Pranay Samala
2026-03-03 1:30 ` Reddy Guddati, Santhosh [this message]
2026-02-23 13:08 ` ✓ Xe.CI.BAT: success for Add helper to select non-joiner mode Patchwork
2026-02-23 13:09 ` ✗ i915.CI.BAT: failure " Patchwork
2026-02-24 5:14 ` ✗ Xe.CI.FULL: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e4bd54c-abbf-47c8-ab30-14a79d1fe536@intel.com \
--to=santhosh.reddy.guddati@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=pranay.samala@intel.com \
--cc=sameer.lattannavar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox