From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CF9E10E38D for ; Wed, 28 Sep 2022 09:14:25 +0000 (UTC) Message-ID: <8e4bdf7f-0b2c-feb6-e42b-aa8a25cf56fc@intel.com> Date: Wed, 28 Sep 2022 14:43:49 +0530 To: Karthik B S , References: <20220909140331.1041095-1-bhanuprakash.modem@intel.com> <20220909140331.1041095-21-bhanuprakash.modem@intel.com> Content-Language: en-US From: "Modem, Bhanuprakash" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: Re: [igt-dev] [i-g-t V3 20/52] tests/kms_multipipe_modeset: Find the suitable mode instead of using default List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On Wed-28-09-2022 02:04 pm, Karthik B S wrote: > On 9/9/2022 7:32 PM, Bhanuprakash Modem wrote: >> This patch will add a check to Skip the subtest if a selected pipe/output >> combo won't support Bigjoiner or 8K mode. >> >> Example: >> * Pipe-D wont support a mode > 5K >> * To use 8K mode on a pipe then consecutive pipe must be available & >> free. >> >> Signed-off-by: Bhanuprakash Modem >> --- >>   tests/kms_multipipe_modeset.c | 9 +++++++++ >>   1 file changed, 9 insertions(+) >> >> diff --git a/tests/kms_multipipe_modeset.c >> b/tests/kms_multipipe_modeset.c >> index 6358d930..6ba6943e 100644 >> --- a/tests/kms_multipipe_modeset.c >> +++ b/tests/kms_multipipe_modeset.c >> @@ -46,6 +46,15 @@ static void run_test(data_t *data, int valid_outputs) >>       drmModeModeInfo *mode; >>       int i = 0; >> +    /* Find suitable mode/resolution combo */ >> +    for_each_connected_output(display, output) { >> +        pipe = &display->pipes[i]; >> +        igt_output_set_pipe(output, i); >> + >> +        i++; >> +    } >> + >> igt_require(igt_override_all_active_output_modes_to_fit_bw(display)); >> + > Agree with the idea of the patch. Please update the commit message for > this subtest as here we're actually reducing the mode from 8k to a mode > that can be supported on single pipe. > With this updated the patch LGTM. Thanks Karthik, I have floated a new rev with this change. - Bhanu > > Thanks, > Karthik.B.S >>       for_each_connected_output(display, output) { >>           mode = igt_output_get_mode(output); >>           igt_assert(mode); > >