Re: [PATCH i-g-t 05/19] lib/kms: Introduce igt_first_crtc_with_single_output()

[Jani Nikula <jani.nikula@intel.com>]

On Wed, 25 Feb 2026, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Several tests just want to find a single CRTC with an output.
> Add a new helper (igt_first_crtc_with_single_output() for it.

Superfluous "(" or missing ")".

>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
>  lib/igt_kms.c | 15 +++++++++++++++
>  lib/igt_kms.h |  2 ++
>  2 files changed, 17 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index bec96f2677ad..ee95afc49aa7 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -7964,3 +7964,18 @@ igt_crtc_t *igt_crtc_for_crtc_id(igt_display_t *display, uint32_t crtc_id)
>  
>  	return NULL;
>  }
> +
> +igt_crtc_t *igt_first_crtc_with_single_output(igt_display_t *display, igt_output_t **ret_output)
> +{
> +	igt_output_t *output;
> +	igt_crtc_t *crtc;
> +
> +	for_each_crtc_with_single_output(display, crtc, output) {
> +		*ret_output = output;
> +		return crtc;
> +	}
> +
> +	*ret_output = NULL;
> +
> +	return NULL;
> +}
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index 5a2dd87b509f..ae488bbf4806 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -575,6 +575,8 @@ int igt_display_n_crtcs(igt_display_t *display);
>  
>  const char *igt_crtc_name(igt_crtc_t *crtc);
>  
> +igt_crtc_t *igt_first_crtc_with_single_output(igt_display_t *display, igt_output_t **ret_output);
> +
>  static inline igt_crtc_t *igt_crtc_for_pipe(igt_display_t *display, enum pipe pipe)
>  {
>  	if (pipe == PIPE_NONE)

-- 
Jani Nikula, Intel