From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D38B10E246 for ; Thu, 1 Jun 2023 10:15:52 +0000 (UTC) Message-ID: <8f9ce4d1-a8b6-bd74-d458-06bca5aac961@intel.com> Date: Thu, 1 Jun 2023 15:45:36 +0530 Content-Language: en-US To: "Hogander, Jouni" , "igt-dev@lists.freedesktop.org" References: <20230601050928.2487611-1-kunal1.joshi@intel.com> <20230601050928.2487611-3-kunal1.joshi@intel.com> From: "Joshi, Kunal1" In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 2/6] RFC Added is_xe to check if xe device List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" List-ID: On 6/1/2023 3:41 PM, Hogander, Jouni wrote: > Hello Kunal, > > Please check my comment below. > > On Thu, 2023-06-01 at 10:39 +0530, Kunal Joshi wrote: >> Added is_xe for test to have XE checks >> >> Signed-off-by: Kunal Joshi >> --- >>  tests/i915/kms_frontbuffer_tracking.c | 8 ++++++++ >>  1 file changed, 8 insertions(+) >> >> diff --git a/tests/i915/kms_frontbuffer_tracking.c >> b/tests/i915/kms_frontbuffer_tracking.c >> index c2b99670..3bef46b6 100644 >> --- a/tests/i915/kms_frontbuffer_tracking.c >> +++ b/tests/i915/kms_frontbuffer_tracking.c >> @@ -309,6 +309,8 @@ struct { >>         .stop = true, >>  }; >> >> +static bool is_xe; > Maybe you could just drop this and use is_xe_device() where you need to > differentiate? > Hello Jouni, Thanks for taking a look, will float changes as you suggested. Regards Kunal Joshi