From: Martin Peres <martin.peres@linux.intel.com>
To: Petri Latvala <petri.latvala@intel.com>, igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 1/1] runner: Add explicit "notrun" results for tests that were not executed
Date: Wed, 5 Dec 2018 16:51:40 +0200 [thread overview]
Message-ID: <9088edff-b5ed-3d92-e3d7-9ec73428822a@linux.intel.com> (raw)
In-Reply-To: <20181113130430.31966-1-petri.latvala@intel.com>
On 13/11/2018 15:04, Petri Latvala wrote:
> When possible, all tests we know we were going to attempt to execute
> now appear in the results as "notrun". The only known case where it's
> not possible to add an explicit "notrun" is when running in
> multiple-mode, because "no subtests" and "run all subtests, we didn't
> list them beforehand" are represented the same.
>
> Note: A function call is commented out in resultgen.c because it needs
> the function to exist, and that's in a patch that is still in flight.
Thanks for doing this!
I checked out the code and tests, and this looks good. However, since I
did not review much code before, I will demote my R-b to:
Acked-by: Martin Peres <martin.peres@linux.intel.com>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
prev parent reply other threads:[~2018-12-05 14:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-13 13:04 [igt-dev] [PATCH i-g-t 1/1] runner: Add explicit "notrun" results for tests that were not executed Petri Latvala
2018-11-13 13:24 ` [igt-dev] ✗ Fi.CI.BAT: failure for series starting with [i-g-t,1/1] " Patchwork
2018-11-13 13:30 ` [igt-dev] [PATCH i-g-t 1/1] " Chris Wilson
2018-11-14 11:33 ` Petri Latvala
2018-11-13 13:52 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/1] " Patchwork
2018-11-13 15:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2018-12-05 14:51 ` Martin Peres [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9088edff-b5ed-3d92-e3d7-9ec73428822a@linux.intel.com \
--to=martin.peres@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=petri.latvala@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox