From: Zack Rusin <zackr@vmware.com>
To: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"kamil.konieczny@linux.intel.com"
<kamil.konieczny@linux.intel.com>
Cc: Martin Krastev <krastevm@vmware.com>,
Michael Banack <banackm@vmware.com>,
Maaz Mombasawala <mombasawalam@vmware.com>,
"reshed@vmware.com" <reshed@vmware.com>
Subject: Re: [igt-dev] [PATCH i-g-t 1/3] igt/vmwgfx: Add support for testing vmwgfx
Date: Thu, 26 Jan 2023 19:06:49 +0000 [thread overview]
Message-ID: <90f64ab34d810000b03ce8dcdf5e432a1c70ce35.camel@vmware.com> (raw)
In-Reply-To: <20230126181321.adqxdug627qve3dv@kamilkon-desk1>
On Thu, 2023-01-26 at 19:13 +0100, Kamil Konieczny wrote:
> !! External Email
>
> Hi,
>
> please rebase and resend. Please also shorten licence,
> we use SPDX to not write out big text (see one example below).
> You can also use checkpatch script from Linux kernel, it will
> provide some hints for improvement.
>
> Please also find someone from vmware for review of vmware
> specific parts of your tests and libs.
I did that. This was written by Maaz and Roy and reviewed by me. I know that some
projects use signed-off differently, usually it implies review, but I'm happy to
provide both reviewed-by and signed-off if that's what you prefer.
z
next prev parent reply other threads:[~2023-01-26 19:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 17:27 [igt-dev] [PATCH i-g-t 0/3] Add vmwgfx support Zack Rusin
2022-11-29 17:27 ` [igt-dev] [PATCH i-g-t 1/3] igt/vmwgfx: Add support for testing vmwgfx Zack Rusin
2023-01-26 18:13 ` Kamil Konieczny
2023-01-26 19:06 ` Zack Rusin [this message]
2023-02-17 17:50 ` Kamil Konieczny
2022-11-29 17:27 ` [igt-dev] [PATCH i-g-t 2/3] lib/igt_kms: vmwgfx returns 8 crtc Zack Rusin
2023-02-17 17:32 ` Kamil Konieczny
2022-11-29 17:27 ` [igt-dev] [PATCH i-g-t 3/3] igt: Switch warning to an info when not using i915 Zack Rusin
2023-01-26 18:17 ` Kamil Konieczny
2023-01-26 19:11 ` Zack Rusin
2023-01-27 14:29 ` Kamil Konieczny
2023-01-27 14:35 ` Petri Latvala
2023-01-27 16:51 ` Kamil Konieczny
2023-02-17 17:35 ` Kamil Konieczny
2022-11-29 19:42 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add vmwgfx support Patchwork
2022-11-29 20:02 ` [igt-dev] ✗ Fi.CI.BAT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90f64ab34d810000b03ce8dcdf5e432a1c70ce35.camel@vmware.com \
--to=zackr@vmware.com \
--cc=banackm@vmware.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
--cc=krastevm@vmware.com \
--cc=mombasawalam@vmware.com \
--cc=reshed@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox