public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>,
	<igt-dev@lists.freedesktop.org>
Cc: <pranay.samala@intel.com>
Subject: Re: [PATCH i-g-t 3/4] tests/kms_color_pipeline: Disable pipe color properties in test setup
Date: Fri, 13 Feb 2026 02:28:41 +0530	[thread overview]
Message-ID: <9124955a-ded7-42a1-80cf-3e675e58a24a@intel.com> (raw)
In-Reply-To: <20260202060415.2680288-3-chaitanya.kumar.borah@intel.com>

Hi Chaitanya,

Patch LGTM

Reviewed-by: Swati Sharma <swati2.sharma@intel.com>

On 02-02-2026 11:34 am, Chaitanya Kumar Borah wrote:
> Move disabling of pipe-level color properties (CTM, degamma, gamma)
> from the individual plane color tests into the common test setup.
>
> Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
> ---
>   tests/kms_color_pipeline.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/tests/kms_color_pipeline.c b/tests/kms_color_pipeline.c
> index dd2eed637..e15f4d79a 100644
> --- a/tests/kms_color_pipeline.c
> +++ b/tests/kms_color_pipeline.c
> @@ -65,6 +65,11 @@ static void test_setup(data_t *data, enum pipe p)
>   	data->pipe_crc = igt_crtc_crc_new(crtc,
>   					  IGT_PIPE_CRC_SOURCE_AUTO);
>   
> +	/* Disable Pipe color props. */
> +	disable_ctm(crtc);
> +	disable_degamma(crtc);
> +	disable_gamma(crtc);
> +
>   	igt_display_commit_atomic(&data->display, DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
>   }
>   
> @@ -107,10 +112,6 @@ static void _test_plane_colorops(data_t *data, enum pipe pipe,
>   				 &fb));
>   	igt_plane_set_fb(plane, &fb);
>   
> -	/* Disable Pipe color props. */
> -	disable_ctm(plane->crtc);
> -	disable_degamma(plane->crtc);
> -	disable_gamma(plane->crtc);
>   	igt_display_commit_atomic(&data->display, 0, NULL);
>   
>   	/* Reference (software-equivalent) CRC */

  reply	other threads:[~2026-02-12 20:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02  6:04 [PATCH i-g-t 1/4] tests/kms_color_pipeline: use atomic commit helper consistently Chaitanya Kumar Borah
2026-02-02  6:04 ` [PATCH i-g-t 2/4] tests/kms_color_pipeline: Run tests on all supported planes Chaitanya Kumar Borah
2026-02-12 20:55   ` Sharma, Swati2
2026-02-02  6:04 ` [PATCH i-g-t 3/4] tests/kms_color_pipeline: Disable pipe color properties in test setup Chaitanya Kumar Borah
2026-02-12 20:58   ` Sharma, Swati2 [this message]
2026-02-02  6:04 ` [PATCH i-g-t 4/4] tests/kms_color_pipeline: collect reference CRC once per pipe Chaitanya Kumar Borah
2026-02-16 20:48   ` Sharma, Swati2
2026-02-17  9:16     ` Borah, Chaitanya Kumar
2026-02-02 21:36 ` ✓ Xe.CI.BAT: success for series starting with [i-g-t,1/4] tests/kms_color_pipeline: use atomic commit helper consistently Patchwork
2026-02-02 21:56 ` ✓ i915.CI.BAT: " Patchwork
2026-02-03  4:32 ` ✗ i915.CI.Full: failure " Patchwork
2026-02-12 20:37 ` [PATCH i-g-t 1/4] " Sharma, Swati2

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9124955a-ded7-42a1-80cf-3e675e58a24a@intel.com \
    --to=swati2.sharma@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=pranay.samala@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox