Re: [PATCH i-g-t, v5 1/4] lib/igt_kms: Add igt_get_joined_pipes_name()

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 30 Apr 2026, Swati Sharma <swati2.sharma@intel.com> wrote:
> Add function to transform the enum into a string.
>
> v2: -Improved func() doc (Jeevan)
> v3: -Return names without '-' dash prefix (Santhosh)
>
> Signed-off-by: Swati Sharma <swati2.sharma@intel.com>
> Reviewed-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  lib/igt_kms.c | 22 ++++++++++++++++++++++
>  lib/igt_kms.h |  1 +
>  2 files changed, 23 insertions(+)
>
> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
> index 2efdfb85f..bece27ff6 100644
> --- a/lib/igt_kms.c
> +++ b/lib/igt_kms.c
> @@ -1906,6 +1906,28 @@ bool kmstest_force_connector_joiner(int drm_fd, drmModeConnector *connector, int
>  	return true;
>  }
>  
> +/**
> + * igt_get_joined_pipes_name:
> + * @val: forced value
> + *
> + * Returns: A joined_pipes enum value into a readable string.
> + */
> +const char *igt_get_joined_pipes_name(enum joined_pipes val)
> +{
> +	switch (val) {
> +	case JOINED_PIPES_DEFAULT:
> +		return "";
> +	case JOINED_PIPES_NONE:
> +		return "none";
> +	case JOINED_PIPES_BIG_JOINER:
> +		return "bigjoiner";
> +	case JOINED_PIPES_ULTRA_JOINER:
> +		return "ultrajoiner";
> +	default:
> +		igt_assert(false);
> +	}
> +}

I don't really think this belongs in lib/igt_kms.[ch]. And to be fair,
IMO none of the joiner code belongs here, because it's Intel specific,
and this is supposed to be generic code.

BR,
Jani.


> +
>  /**
>   * kmstest_force_edid:
>   * @drm_fd: drm file descriptor
> diff --git a/lib/igt_kms.h b/lib/igt_kms.h
> index fcbb6a5ad..6898cd981 100644
> --- a/lib/igt_kms.h
> +++ b/lib/igt_kms.h
> @@ -1280,6 +1280,7 @@ void igt_set_link_params(int drm_fd, igt_output_t *output,
>  int igt_backlight_read(int *result, const char *fname, igt_backlight_context_t *context);
>  int igt_backlight_write(int value, const char *fname, igt_backlight_context_t *context);
>  uint32_t igt_get_connected_output_count(igt_display_t *display);
> +const char *igt_get_joined_pipes_name(enum joined_pipes val);
>  
>  drmModePropertyBlobRes *igt_get_writeback_formats_blob(igt_output_t *output);

-- 
Jani Nikula, Intel