From: "Bernatowicz, Marcin" <marcin.bernatowicz@linux.intel.com>
To: Adam Miszczak <adam.miszczak@linux.intel.com>,
igt-dev@lists.freedesktop.org
Cc: kamil.konieczny@linux.intel.com
Subject: Re: [PATCH i-g-t 2/3] tools/vmtb: Skip double migration tests on no-debug config
Date: Fri, 16 Oct 2026 19:02:18 +0200 [thread overview]
Message-ID: <91ba5d81-96a3-4697-8fd1-c81aa287e9f8@linux.intel.com> (raw)
In-Reply-To: <20261015071037.10898-3-adam.miszczak@linux.intel.com>
LGTM,
Reviewed-by: Marcin Bernatowicz <marcin.bernatowicz@linux.intel.com>
On 10/15/2026 9:10 AM, Adam Miszczak wrote:
> Double migration tests depend on the debugfs 'resfix_stoppers' hook,
> which is only exposed in a KMD debug build.
> Add autoused 'is_test_supported' fixture to BaseTestDoubleMigration
> that probes for the hook and skips test execution when it's absent
> on a guest (first VM).
>
> Signed-off-by: Adam Miszczak <adam.miszczak@linux.intel.com>
> ---
> tools/vmtb/vmm_flows/test_migration.py | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/tools/vmtb/vmm_flows/test_migration.py b/tools/vmtb/vmm_flows/test_migration.py
> index 6853d87f4..c4f3f00a4 100644
> --- a/tools/vmtb/vmm_flows/test_migration.py
> +++ b/tools/vmtb/vmm_flows/test_migration.py
> @@ -785,6 +785,19 @@ class BaseTestDoubleMigration:
> - restoring from initial (1st) or latter (2nd) migration
> """
>
> + @pytest.fixture(scope='class', autouse=True, name='is_test_supported')
> + def fixture_is_test_supported(self, setup_vms):
> + """Skip test on no-debug setup lacking the required debugfs 'resfix_stoppers' hook."""
> + ts: VmmTestingSetup = setup_vms
> + vm: VirtualMachine = ts.get_vm[0]
> + vm_debugfs_path = vm.get_dut().driver.debugfs_path
> +
> + try:
> + vm.read_file_content(f'{vm_debugfs_path}/gt0/vf/resfix_stoppers')
> + except exceptions.GuestError:
> + logger.warning("Required debug hook not found (KMD no-debug config?)")
> + pytest.skip("Test scenario not supported on no-debug config")
> +
> def __set_debugfs_resfix_stoppers(self, vm: VirtualMachine, stage: ResfixWaitStage):
> """Set resfix_stoppers:
> predefined checkpoints that allow the migration process to pause at specific stages.
next prev parent reply other threads:[~2026-10-16 17:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 7:10 [PATCH i-g-t 0/3] tools/vmtb: Parallel multi-VM migration and tests reconfiguration Adam Miszczak
2026-10-15 7:10 ` [PATCH i-g-t 1/3] tools/vmtb: Support parallel multi-VM busy migration Adam Miszczak
2026-10-16 17:01 ` Bernatowicz, Marcin
2026-10-15 7:10 ` [PATCH i-g-t 2/3] tools/vmtb: Skip double migration tests on no-debug config Adam Miszczak
2026-10-16 17:02 ` Bernatowicz, Marcin [this message]
2026-10-15 7:10 ` [PATCH i-g-t 3/3] tools/vmtb: Reconfigure tests setup Adam Miszczak
2026-10-16 17:02 ` Bernatowicz, Marcin
2026-10-15 9:05 ` ✓ i915.CI.BAT: success for tools/vmtb: Parallel multi-VM migration and tests reconfiguration Patchwork
2026-10-15 11:37 ` ✓ i915.CI.Full: " Patchwork
2026-10-15 15:21 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-15 20:09 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-10-15 21:35 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=91ba5d81-96a3-4697-8fd1-c81aa287e9f8@linux.intel.com \
--to=marcin.bernatowicz@linux.intel.com \
--cc=adam.miszczak@linux.intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox