public inbox for igt-dev@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Sharma, Nishit" <nishit.sharma@intel.com>
To: Arvind Yadav <arvind.yadav@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <matthew.brost@intel.com>, <himal.prasad.ghimiray@intel.com>,
	<thomas.hellstrom@linux.intel.com>, <pravalika.gurram@intel.com>
Subject: Re: [PATCH i-g-t v6 5/9] tests/intel/xe_madvise: Add dontneed-after-mmap subtest
Date: Mon, 6 Apr 2026 19:03:51 +0530	[thread overview]
Message-ID: <928258d0-0e95-465e-9cc4-f1ca8846deb2@intel.com> (raw)
In-Reply-To: <20260325124426.3265234-6-arvind.yadav@intel.com>


On 3/25/2026 6:14 PM, Arvind Yadav wrote:
> This test verifies that an existing mmap becomes invalid after the BO
> is marked as purgeable and purged. The test creates a BO, maps it,
> writes data, then marks it DONTNEED and triggers memory pressure.
> Accessing the previously valid mapping should now trigger SIGBUS or
> SIGSEGV, confirming that existing mappings are correctly invalidated
> when the backing store is purged.
>
> v4:
>    - Added proper resource cleanup before calling igt_skip(). (Nishit)
>    - Added assertion for xe_bo_map. (Nishit)
>
> v6:
>    - Fix sigsetjmp(jmp, SIGBUS | SIGSEGV) to sigsetjmp(jmp, 1). The
>      second argument is a plain boolean savemask, not a signal set.
>
> Cc: Nishit Sharma <nishit.sharma@intel.com>
> Cc: Matthew Brost <matthew.brost@intel.com>
> Cc: Thomas Hellström <thomas.hellstrom@linux.intel.com>
> Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
> Cc: Pravalika Gurram <pravalika.gurram@intel.com>
> Signed-off-by: Arvind Yadav <arvind.yadav@intel.com>
> ---
>   tests/intel/xe_madvise.c | 64 ++++++++++++++++++++++++++++++++++++++++
>   1 file changed, 64 insertions(+)
>
> diff --git a/tests/intel/xe_madvise.c b/tests/intel/xe_madvise.c
> index 81e05b6d4..9a157de1d 100644
> --- a/tests/intel/xe_madvise.c
> +++ b/tests/intel/xe_madvise.c
> @@ -244,6 +244,64 @@ static void test_dontneed_before_mmap(int fd)
>   	xe_vm_destroy(fd, vm);
>   }
>   
> +/**
> + * SUBTEST: dontneed-after-mmap
> + * Description: Mark BO as DONTNEED after mmap, verify SIGBUS on accessing purged mapping
> + * Test category: functionality test
> + */
> +static void test_dontneed_after_mmap(int fd)
> +{
> +	uint32_t bo, vm;
> +	uint64_t addr = PURGEABLE_ADDR;
> +	size_t bo_size = PURGEABLE_BO_SIZE;
> +	void *map;
> +
> +	purgeable_setup_simple_bo(fd, &vm, &bo, addr, bo_size, true);
> +
> +	map = xe_bo_map(fd, bo, bo_size);
> +	igt_assert(map != MAP_FAILED);
> +	memset(map, 0xAB, bo_size);
> +
> +	if (!purgeable_mark_and_verify_purged(fd, vm, addr, bo_size)) {
same comment as in Patch-4/9
> +		munmap(map, bo_size);
> +		gem_close(fd, bo);
> +		xe_vm_destroy(fd, vm);
> +		igt_skip("Unable to induce purge on this platform/config");
> +	}
> +
> +	/* Access purged mapping - should trigger SIGBUS/SIGSEGV */
> +	{
> +		sighandler_t old_sigsegv, old_sigbus;
> +		char *ptr = (char *)map;
> +		int sig;
> +
> +		old_sigsegv = signal(SIGSEGV, (__sighandler_t)sigtrap);
> +		old_sigbus = signal(SIGBUS, (__sighandler_t)sigtrap);
> +
> +		sig = sigsetjmp(jmp, 1); /* savemask=1: save/restore signal mask */
> +		switch (sig) {
> +		case SIGBUS:
> +		case SIGSEGV:
> +			/* Expected - purged mapping access failed */
> +			break;
> +		case 0:
> +			*ptr = 0;
> +		default:
> +			igt_assert_f(false,
> +				     "Access to purged mapping should trigger SIGBUS, got sig=%d\n",
> +				     sig);
> +			break;
> +		}
> +
> +		signal(SIGBUS, old_sigbus);
> +		signal(SIGSEGV, old_sigsegv);
> +	}
> +
> +	munmap(map, bo_size);
> +	gem_close(fd, bo);
> +	xe_vm_destroy(fd, vm);
> +}
> +
>   int igt_main()
>   {
>   	struct drm_xe_engine_class_instance *hwe;
> @@ -268,6 +326,12 @@ int igt_main()
>   			break;
>   		}
>   
> +	igt_subtest("dontneed-after-mmap")
> +		xe_for_each_engine(fd, hwe) {
> +			test_dontneed_after_mmap(fd);
> +			break;
> +		}
> +
>   	igt_fixture() {
>   		xe_device_put(fd);
>   		drm_close_driver(fd);

  reply	other threads:[~2026-04-06 13:35 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-25 12:44 [PATCH i-g-t v6 0/9] tests/xe: Add purgeable memory madvise tests for system allocator Arvind Yadav
2026-03-25 12:44 ` [PATCH i-g-t v6 1/9] drm-uapi/xe_drm: Add UAPI support for purgeable buffer objects Arvind Yadav
2026-04-06  5:23   ` Sharma, Nishit
2026-04-06  6:00     ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 2/9] lib/xe: Add purgeable memory ioctl support Arvind Yadav
2026-04-06  6:59   ` Sharma, Nishit
2026-04-07  3:18     ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 3/9] tests/intel/xe_madvise: Add dontneed-before-mmap subtest Arvind Yadav
2026-04-06  9:53   ` Sharma, Nishit
2026-04-06 10:30     ` Sharma, Nishit
2026-04-07  4:21       ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 4/9] tests/intel/xe_madvise: Add purged-mmap-blocked subtest Arvind Yadav
2026-04-06 12:34   ` Sharma, Nishit
2026-04-07  5:09     ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 5/9] tests/intel/xe_madvise: Add dontneed-after-mmap subtest Arvind Yadav
2026-04-06 13:33   ` Sharma, Nishit [this message]
2026-04-07  5:15     ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 6/9] tests/intel/xe_madvise: Add dontneed-before-exec subtest Arvind Yadav
2026-04-06 16:48   ` Sharma, Nishit
2026-04-07  5:29     ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 7/9] tests/intel/xe_madvise: Add dontneed-after-exec subtest Arvind Yadav
2026-04-07 14:51   ` Sharma, Nishit
2026-03-25 12:44 ` [PATCH i-g-t v6 8/9] tests/intel/xe_madvise: Add per-vma-tracking subtest Arvind Yadav
2026-04-07  7:20   ` Sharma, Nishit
2026-04-07  8:49     ` Yadav, Arvind
2026-03-25 12:44 ` [PATCH i-g-t v6 9/9] tests/intel/xe_madvise: Add per-vma-protection subtest Arvind Yadav
2026-04-07  7:31   ` Sharma, Nishit
2026-04-07  8:54     ` Yadav, Arvind
2026-03-25 22:59 ` ✓ Xe.CI.BAT: success for tests/xe: Add purgeable memory madvise tests for system allocator (rev6) Patchwork
2026-03-25 23:15 ` ✓ i915.CI.BAT: " Patchwork
2026-03-26  9:19 ` ✗ Xe.CI.FULL: failure " Patchwork
2026-03-26 11:22 ` ✓ i915.CI.Full: success " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=928258d0-0e95-465e-9cc4-f1ca8846deb2@intel.com \
    --to=nishit.sharma@intel.com \
    --cc=arvind.yadav@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=matthew.brost@intel.com \
    --cc=pravalika.gurram@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox