From: Guillaume Tucker <guillaume.tucker@collabora.com>
To: "Ser, Simon" <simon.ser@intel.com>,
"Hiler, Arkadiusz" <arkadiusz.hiler@intel.com>
Cc: "igt-dev@lists.freedesktop.org" <igt-dev@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/4] gitlab-ci: add libatomic to Fedora docker image
Date: Thu, 13 Jun 2019 13:56:36 +0100 [thread overview]
Message-ID: <92c16b42-a667-370e-0217-23af165a9529@collabora.com> (raw)
In-Reply-To: <b6543a8d7086abe7a15a5fe689de6ead0fbe62f1.camel@intel.com>
On 06/06/2019 08:26, Ser, Simon wrote:
> On Thu, 2019-06-06 at 10:21 +0300, Arkadiusz Hiler wrote:
>> On Mon, Jun 03, 2019 at 12:54:48PM +0100, Guillaume Tucker wrote:
>>> Add libatomic to the Fedora docker image so it can link binaries that
>>> use __atomic_* functions.
>>>
>>> Signed-off-by: Guillaume Tucker <guillaume.tucker@collabora.com>
>>> ---
>>> Dockerfile.fedora | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Dockerfile.fedora b/Dockerfile.fedora
>>> index 6686e587613d..c84b412b0723 100644
>>> --- a/Dockerfile.fedora
>>> +++ b/Dockerfile.fedora
>>> @@ -1,7 +1,7 @@
>>> FROM fedora:30
>>>
>>> RUN dnf install -y \
>>> - gcc flex bison meson ninja-build xdotool \
>>> + gcc flex bison libatomic meson ninja-build xdotool \
>>> 'pkgconfig(libdrm)' \
>>> 'pkgconfig(pciaccess)' \
>>> 'pkgconfig(libkmod)' \
>>
>> Reviewed-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
>>
>> I wonder how does the libatomic gets installed implicitly in Debian.
>
> It's a dependency of GCC. Probably a good idea to add it anyway?
Fair enough, I'm adding it in the v2.
Guillaume
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-06-13 12:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-03 11:54 [igt-dev] [PATCH i-g-t 1/4] tests: add libatomic dependency Guillaume Tucker
2019-06-03 11:54 ` [igt-dev] [PATCH i-g-t 2/4] gitlab-ci: add libatomic to Fedora docker image Guillaume Tucker
2019-06-06 7:21 ` Arkadiusz Hiler
2019-06-06 7:26 ` Ser, Simon
2019-06-13 12:56 ` Guillaume Tucker [this message]
2019-06-03 11:54 ` [igt-dev] [PATCH i-g-t 3/4] i915/gem_create: use __atomic_* instead of __sync_* Guillaume Tucker
2019-06-06 7:20 ` [Intel-gfx] " Ser, Simon
2019-06-13 13:03 ` Guillaume Tucker
2019-06-03 11:54 ` [Intel-gfx] [PATCH i-g-t 4/4] tests/sw_sync: " Guillaume Tucker
2019-06-03 13:04 ` [igt-dev] ✓ Fi.CI.BAT: success for series starting with [i-g-t,1/4] tests: add libatomic dependency Patchwork
2019-06-03 16:38 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
2019-06-06 7:18 ` [igt-dev] [PATCH i-g-t 1/4] " Ser, Simon
2019-06-13 12:55 ` Guillaume Tucker
2019-06-13 12:57 ` Ser, Simon
2019-06-06 7:19 ` [Intel-gfx] " Arkadiusz Hiler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92c16b42-a667-370e-0217-23af165a9529@collabora.com \
--to=guillaume.tucker@collabora.com \
--cc=arkadiusz.hiler@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=simon.ser@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox