From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Mitul Golani <mitulkumar.ajitkumar.golani@intel.com>,
igt-dev@lists.freedesktop.org
Cc: bhanuprakash.modem@intel.com
Subject: Re: [PATCH] tests/kms_vrr: Avoid race between freeing display reseources
Date: Sat, 31 Aug 2024 10:39:13 +0200 [thread overview]
Message-ID: <9326496c-6263-4d51-a415-90d2fb23f199@linux.intel.com> (raw)
In-Reply-To: <20240831055845.2839510-1-mitulkumar.ajitkumar.golani@intel.com>
Hey,
The sleep seems a workaround.
Can't you just do a blocking commit to disable everything instead?
igt_display_reset()
igt_display_commit2() before igt_display_fini
Den 2024-08-31 kl. 07:58, skrev Mitul Golani:
> While freeing display resources, that schedules driver to execute
> panel power off, which races while scheduling next immediate test.
> Giving time after freeing resources allows driver to avoid race
> between next non blocking atomic commit and panel power off from
> previous test.
> ---
> tests/kms_vrr.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
> index 36a22eebe..481a4253f 100644
> --- a/tests/kms_vrr.c
> +++ b/tests/kms_vrr.c
> @@ -1110,5 +1110,7 @@ igt_main_args("drs:", long_opts, help_str, opt_handler, &data)
> igt_fixture {
> igt_display_fini(&data.display);
> drm_close_driver(data.drm_fd);
> + //Wait for 2 seconds to free-up acquired display resources
> + sleep(2);
> }
> }
next prev parent reply other threads:[~2024-08-31 8:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 5:58 [PATCH] tests/kms_vrr: Avoid race between freeing display reseources Mitul Golani
2024-08-31 6:49 ` ✓ CI.xeBAT: success for " Patchwork
2024-08-31 7:02 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-08-31 8:39 ` Maarten Lankhorst [this message]
2024-08-31 12:55 ` ✓ CI.xeFULL: success " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2024-09-10 5:29 [PATCH] " Jeevan B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9326496c-6263-4d51-a415-90d2fb23f199@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=mitulkumar.ajitkumar.golani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox