From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <igt-dev-bounces@lists.freedesktop.org>
Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9604410E4B7
 for <igt-dev@lists.freedesktop.org>; Thu,  6 Jul 2023 09:30:52 +0000 (UTC)
Message-ID: <94805258-89ee-d0b2-2f24-57f70e8e5759@intel.com>
Date: Thu, 6 Jul 2023 11:30:36 +0200
Content-Language: en-US
To: =?UTF-8?Q?Zbigniew_Kempczy=c5=84ski?= <zbigniew.kempczynski@intel.com>
References: <20230706060555.282757-1-zbigniew.kempczynski@intel.com>
 <20230706060555.282757-4-zbigniew.kempczynski@intel.com>
From: Karolina Stolarek <karolina.stolarek@intel.com>
In-Reply-To: <20230706060555.282757-4-zbigniew.kempczynski@intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
Subject: Re: [igt-dev] [PATCH i-g-t v2 03/16] lib/intel_allocator: Remove
 extensive debugging
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/igt-dev>
List-Post: <mailto:igt-dev@lists.freedesktop.org>
List-Help: <mailto:igt-dev-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/igt-dev>,
 <mailto:igt-dev-request@lists.freedesktop.org?subject=subscribe>
Cc: igt-dev@lists.freedesktop.org
Errors-To: igt-dev-bounces@lists.freedesktop.org
Sender: "igt-dev" <igt-dev-bounces@lists.freedesktop.org>
List-ID: <igt-dev@lists.freedesktop.org>

On 6.07.2023 08:05, Zbigniew Kempczyński wrote:
> Debugging map keys comparison leads to produce extensive logging what
> in turn obscures analysis. Remove it to get clearer logs.

Logging you've introduced with this series is much clearer, thanks for 
doing this:

Reviewed-by: Karolina Stolarek <karolina.stolarek@intel.com>

> 
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
> ---
>   lib/intel_allocator.c | 9 ---------
>   1 file changed, 9 deletions(-)
> 
> diff --git a/lib/intel_allocator.c b/lib/intel_allocator.c
> index c31576ecef..be24f8f2d0 100644
> --- a/lib/intel_allocator.c
> +++ b/lib/intel_allocator.c
> @@ -1385,9 +1385,6 @@ static int equal_handles(const void *key1, const void *key2)
>   {
>   	const struct handle_entry *h1 = key1, *h2 = key2;
>   
> -	alloc_debug("h1: %llx, h2: %llx\n",
> -		   (long long) h1->handle, (long long) h2->handle);
> -
>   	return h1->handle == h2->handle;
>   }
>   
> @@ -1395,9 +1392,6 @@ static int equal_ctx(const void *key1, const void *key2)
>   {
>   	const struct allocator *a1 = key1, *a2 = key2;
>   
> -	alloc_debug("a1: <fd: %d, ctx: %u>, a2 <fd: %d, ctx: %u>\n",
> -		   a1->fd, a1->ctx, a2->fd, a2->ctx);
> -
>   	return a1->fd == a2->fd && a1->ctx == a2->ctx;
>   }
>   
> @@ -1405,9 +1399,6 @@ static int equal_vm(const void *key1, const void *key2)
>   {
>   	const struct allocator *a1 = key1, *a2 = key2;
>   
> -	alloc_debug("a1: <fd: %d, vm: %u>, a2 <fd: %d, vm: %u>\n",
> -		   a1->fd, a1->vm, a2->fd, a2->vm);
> -
>   	return a1->fd == a2->fd && a1->vm == a2->vm;
>   }
>