From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5C085C48291 for ; Fri, 2 Feb 2024 10:27:24 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E085C10E548; Fri, 2 Feb 2024 10:27:23 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="XhFdtq+A"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by gabe.freedesktop.org (Postfix) with ESMTPS id 16D1A10E897 for ; Fri, 2 Feb 2024 05:33:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1706852038; x=1738388038; h=message-id:date:subject:to:cc:references:from: in-reply-to:mime-version; bh=ZeXfPxHxxdYgsV2gUmFjed17ump/DkmxS+yN7ACmNCc=; b=XhFdtq+AawGkFyIEOCKRfb0eUq9m3sqCeR9FSz96a+JC7k/5g294rVOR X2kTaYEEigH/4PD40k6xzp85DliHpTcfyvjKog5EMoqcbma1cXlV11xAx iOudyzkzuaunH+9xndsJwF1sXimj4YnlpAyie1GDjWa6vNY8jmD7u++1t bqQ8k53eJqcC6sROfK7CA2IjQzAXqMBlIpZIH0URcVLfkQWpbMK1Tb0Mn g77+l7Kz6VUJOEoxKqVaBZqvfHEsecpYPWWJLrq7IqqnzkMBFct8HRRMx kNBp/rTEZJMEySI3eDzGIJInUj0VwOk966QSNZzQ5lh3+C6HI812pUigl Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="11188447" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208,217";a="11188447" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Feb 2024 21:33:57 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10971"; a="859330540" X-IronPort-AV: E=Sophos;i="6.05,237,1701158400"; d="scan'208,217";a="859330540" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 01 Feb 2024 21:33:57 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 21:33:56 -0800 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 1 Feb 2024 21:33:55 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 1 Feb 2024 21:33:55 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 1 Feb 2024 21:33:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BnJlvb7MDnJYMLMSllciseBUxIGo3bA0NPvRyZvDxcmQxbXOV4JG58JSXfHdndZEqn19EAPpU0y3qkjHgZRJ6Rmmx4nttsW7CH3yp8HvFX6ISdvW15agD1e3ZpFR8FD1IN9KdLk+N9pRcLhXgoRM/N4S5L0Taa0bS6SyZlhnkmbX6jtwcH+onbBEGSUn8JYkozP5910r6jmoOzGrObNMFtb4DrWNlM3ye8J5qodXXEjU6Ck25gq0ISZTcsRZoZ0LVw+UYlDOIqEInHFeI3FKzCRS6f5mVDBa4abYQmZT1sXFx2lKG6GwVWVUWNiKOKmc4Vil0jbaOWDKJhlavHeIFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TdAcD9dJtMfGv+4gbPgpRjaQfsu/6J6deaSU9//WNIE=; b=ILCanQe+7Rtg/lnGruGMMLr+9m5TFv82IAfDhq/H4ld65sUBjZF++gqP0RnO1Zs/rU0JcYdhBPCVr37HLMvC3fL+r2Wt9XIi3skWTv+9BG5T1pVehB3tuZWcs/y5c+9QBVD5o6v8QAXke7REIlb5cxek3W8g4wISl0gA0LpxG49CIvuPOLm9R3T13L0ZdlxzXwbNulgPI8oRglhcPhAnJ5xgpRW7pAk1puvPfewNK/j+tB6VCYpq0r8uSmthIR4ek5edB5nqUgUe7og3BqAN4sCIqGnNOyh1YUcpYH6Sm58puTG9GD8UMI9/VScBAL5YjYl3nXeMrMQ7Cnq0Kwyjqg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from CO1PR11MB4977.namprd11.prod.outlook.com (2603:10b6:303:6d::14) by MN6PR11MB8145.namprd11.prod.outlook.com (2603:10b6:208:474::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.24; Fri, 2 Feb 2024 05:33:52 +0000 Received: from CO1PR11MB4977.namprd11.prod.outlook.com ([fe80::57c7:cb8d:3964:5f91]) by CO1PR11MB4977.namprd11.prod.outlook.com ([fe80::57c7:cb8d:3964:5f91%7]) with mapi id 15.20.7249.027; Fri, 2 Feb 2024 05:33:52 +0000 Content-Type: multipart/alternative; boundary="------------PaVYZhUcmGkO3hBJipRlFRll" Message-ID: <94889edf-c50b-473b-9d9b-8d2f581d58b3@intel.com> Date: Thu, 1 Feb 2024 21:33:50 -0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH i-g-t v2 1/3] lib/intel_device_info: set has_flatccs on LNL Content-Language: en-US To: Matthew Auld , CC: =?UTF-8?Q?Zbigniew_Kempczy=C5=84ski?= References: <20240201103017.321466-1-matthew.auld@intel.com> From: "Jahagirdar, Akshata" In-Reply-To: <20240201103017.321466-1-matthew.auld@intel.com> X-ClientProxiedBy: MW4PR04CA0118.namprd04.prod.outlook.com (2603:10b6:303:83::33) To CO1PR11MB4977.namprd11.prod.outlook.com (2603:10b6:303:6d::14) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PR11MB4977:EE_|MN6PR11MB8145:EE_ X-MS-Office365-Filtering-Correlation-Id: 53058067-1731-4998-b1de-08dc23b08a64 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: uAIxObkcemhJLkCVWMUJ6crCDprK6+X9zBOOrziAzldohJREno5z4MDj1i09mUUHQnetDthMrnq1Arlmv3NQ9aSgJGu4uLrIbF1X8dXUL8zbdnDVAdd3+E+pkD4VXIad/et8dJ7yCg0h3DwM1PNhktk9XU7hfECk+XMZWAj9plDhbc6mqKfyp2InXbGcIDeOoSjTcE8mTw55yxiDlGmbH2KKyYDb5+H0SfcTRi7I3snjYCajZq8vvWbOM55Yi4AaYD+SWTZmNk1Oj0l9JREQkpAPo48+elnTCN7dd4Zv0DuhAdICvjFmjUIV1i35wNm2UDMIARblLXTv4t9PG+rlFCfzaE5YJp3azWXKYt5N/nKv7aLAsJoGOkZU8awIwIUARXKU0k3raCYI1CjDxaD0A/EMugFY68CIjSlrqZxkTRd2j58nNU6WuiTZ15cICNRXnu9VlfrkeE9R9J7hHjdCMylSpvu4GELIABCE/1mN2CeWMVWs9JeBtefzKj66f5O+eGv4Esxie93fkKhIyKBASJL1zLY5ntLDb1e0ZU76wX82Nj0UJAo6PxRv36N6p0wi3Ln6i01TAZemUwIDj41sXldehfRLKv/UnN/bBpDzAq0vs7lGdxeqhbIJdGx1QELEag6qkG12m0TxhL8EXUH38Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CO1PR11MB4977.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(346002)(376002)(396003)(39860400002)(136003)(366004)(230922051799003)(1800799012)(451199024)(186009)(64100799003)(41300700001)(2616005)(38100700002)(26005)(107886003)(6512007)(8936002)(4326008)(66476007)(6486002)(6506007)(66556008)(33964004)(8676002)(2906002)(53546011)(316002)(478600001)(66946007)(5660300002)(36756003)(82960400001)(31696002)(86362001)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NHdOSms2RlIycHN3QVBFbHVxVWp6T1A3NzM2eDRXaUt4QnErYjVWQml0MzQ4?= =?utf-8?B?dkRlTXdaTm9mcXFVUEt3SXJBSmdwVndmSmg4dFhrSUxQditIRkRjbHpwSmpv?= =?utf-8?B?eG1vRCtFMFM2RmZiZzRnNzVlRC95NnhCUmdtNGNYQ00wQUlpdWJDQnE2N0Zr?= =?utf-8?B?VEJOak9HS1haejlqSS9MTGxoZUhXRjNXc1hMK1pXSDNCamJoaldON0FoUzVV?= =?utf-8?B?N0xzaFp1VWQrZU5IZEYvVDNxSGxpTGM4RVVHN2V3a1RQUUwzSDlJZTRGdHkv?= =?utf-8?B?ZjJ3S1V6L0Y2eXl3WmxOSVhUQXFQWlBNVTRvNFNmdTFmb3c4OTlRaERPZTZB?= =?utf-8?B?NVpoMkZ3Wm5FdFZWNTNRUjRTTlZGMGVjS1BsUGhYcFlHdVcySTZYeTFDdjRE?= =?utf-8?B?U0FIYnFNSEpPS3QwbUUraTY0NEtxTEEyMkpGYnJkWTJEOW1UMzc5NHdnUFJ1?= =?utf-8?B?MHRQWVkvYW5vRDF2WnlacmdaaXg2N2N1Tkc3T0FkV0VweE0zS2R4M1JFdkVh?= =?utf-8?B?RDBjcHR1VllSMXhSNXFrWW9hNi9OSnJRbmowOVRkNTNTZXNVa1o1MEk4YUZw?= =?utf-8?B?WVoxZ2lTK0Q3RUFtVFZ4NmFKNUczQlFudlZXcHlHaDd3d2psb2k5bENJMHNq?= =?utf-8?B?ODFCbk5mQlFtd2xwaU13NUs3SENJSjdwdXFwK1I2bkVhbmhmeTFYLzFqVDFn?= =?utf-8?B?aFdUeHh1d3hOekI0YU9JSFZ0UkdjSkdSVE1VSmFuLzlZUFhVakdmSTdRRVlW?= =?utf-8?B?T3M5Qit6TWxoOEFCWGRHTDhvczArQVo5S25yeStrR0F3SmdnR3lHM0dmRG9h?= =?utf-8?B?N0ZpemRWdFo5YmtubXlPODFFcncyRVNDS09ZTE5mZE9aOHdlQXZVaVA5STFl?= =?utf-8?B?K1JHR2lPUzJoTUFTZlpmQUM1L1NLS25GR1RYdkZwdUhYcFJTYkJDdEQ2MXph?= =?utf-8?B?b3BqOWVMcVNSMUNXbHhxNU9SQzlRb0JNUlFqbGs4YU92TkpXc213T05hbnE1?= =?utf-8?B?a1k4MzB6eWQzS3U0MmJ6Q2R4Q2g4OS9NamhpcXRMZVIwQ202RjJIRzVmUnlW?= =?utf-8?B?aDJBZ3AyM1lHcFkrZG5XQ1c4Tmp5QmY4NUE2N2Z2MXRzYnp2QVQvS3ZVcjBP?= =?utf-8?B?NnNYYnRGRjBCV3JjMHg1bFljYmZib2NzZG11QUUwN0dnejArRnRROUcvMlUw?= =?utf-8?B?Q2hpdi9IaXpQYlUvTVFsd1ZXVnpoeTJzcFZBKzlIMUozbWVRdDV0M0dlcTRw?= =?utf-8?B?OEhCQUVaQ3BUN0ZGYXlXaWIrdHNvUzhhRXZHd0NkalZURURRV1B1UVhYcHAz?= =?utf-8?B?OVoxNERsbW9mSDVudmxOZkxDeUQ3YWlsNk1JVEs3SVJhbnJjTnQ1TXdIdVB4?= =?utf-8?B?VDZtMWk0RkxKR05zeG9obCtTSTdUQy92VjJzVmw5RFVTWi91SithVjRJeXlB?= =?utf-8?B?U0xZMlBnMkNkaCs5RGF2U0owdFNJWHpQdWo3Vkh6bjdkOGtSd3JqRk0zWjRl?= =?utf-8?B?bTZDSUFkVUcwNCsxSEo4dmo0OWpBNjUzanZFSW5IelMrazhqcHpvVHF1NXJH?= =?utf-8?B?M2gzdldwaTExSjhBU2NHeGRmM1JzY1RRLzhwb2RpRHJPM1NjbTZ6OFpYU0l3?= =?utf-8?B?S2Y3bGJ5ZC9kZGxqMUdFNm5FY2ovQlZtV2cvT0xJQnNCU3BSZWYxQkEyVFAw?= =?utf-8?B?WW5nSFVraXhOcEFWTUNwSGZ4RGFGSlVqQmk3MnNQalpjb0tkS2VNc3UzTVZ5?= =?utf-8?B?d1ZtRjlSMTZXVW5Kb2p2VHFYYWJtYWZtZTVXRWMzZmVtRXdNSzhES25XTWpC?= =?utf-8?B?bFdHcDRDSHpDbnpjdlh5Smg3clRZS0cwWE5DWmpjVjhoc3lRWmlEb29JTDlZ?= =?utf-8?B?VFZGT3hOQzRGd1pYdjc0eHM4VlhBckZiS0ZFVGM0ZVJGK2pmMW5wWk9RWkhI?= =?utf-8?B?VWZaR2dnNjNrTmlkZ3JoSXBlU1c4Q2pFTjdYUWtJN3VFWWx6amplZWgxS0t0?= =?utf-8?B?K1Ivb1pPZ09zaGVsSFFPMFBCTCsxTEZjUEJ4eUlJdDV2UU9QaUI4NTBMaCtp?= =?utf-8?B?VWdLTjZlTjdBNVdibHNZM1pwcTI0aVUyeVE4SWhLQnlIb3V6NThXYVgvQnl4?= =?utf-8?B?MFdpVjRPQmlDK1hhK2MzOTlHVkVsazdLTHcxaDkwYS9LOUNhYnMzNldKdWl5?= =?utf-8?B?T2c9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 53058067-1731-4998-b1de-08dc23b08a64 X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB4977.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 05:33:52.7336 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 25q3o7rhMucVYpTTVb7Qufj+MC8eR5fRPLB/A9L4lJxlyIaikGSRCJXnKBdA6eu+NuoJj9yA8PNrg0BPDieZVizr4NGfIe68mLYFMDai1Do= X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8145 X-OriginatorOrg: intel.com X-Mailman-Approved-At: Fri, 02 Feb 2024 10:27:22 +0000 X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" --------------PaVYZhUcmGkO3hBJipRlFRll Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit On 2/1/2024 2:30 AM, Matthew Auld wrote: > Xe2 supports flat CCS based compression, including igpu. Currently > HAS_FLATCCS() is incorrectly returning false on LNL. > > Signed-off-by: Matthew Auld > Cc: Akshata Jahagirdar > Cc: Zbigniew Kempczyński > Reviewed-by: Zbigniew Kempczyński > --- > lib/intel_device_info.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c > index a669797c3..64b5246b7 100644 > --- a/lib/intel_device_info.c > +++ b/lib/intel_device_info.c > @@ -509,6 +509,7 @@ static const struct intel_device_info intel_lunarlake_info = { > .graphics_rel = 4, > .display_ver = 20, > .has_4tile = true, > + .has_flatccs = true, > .is_lunarlake = true, > .codename = "lunarlake", > .cmds_info = &xe2_cmds_info, Reviewed-by: Akshata Jahagirdar > --------------PaVYZhUcmGkO3hBJipRlFRll Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: 8bit


On 2/1/2024 2:30 AM, Matthew Auld wrote:
Xe2 supports flat CCS based compression, including igpu. Currently
HAS_FLATCCS() is incorrectly returning false on LNL.

Signed-off-by: Matthew Auld <matthew.auld@intel.com>
Cc: Akshata Jahagirdar <akshata.jahagirdar@intel.com>
Cc: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski@intel.com>
---
 lib/intel_device_info.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
index a669797c3..64b5246b7 100644
--- a/lib/intel_device_info.c
+++ b/lib/intel_device_info.c
@@ -509,6 +509,7 @@ static const struct intel_device_info intel_lunarlake_info = {
 	.graphics_rel = 4,
 	.display_ver = 20,
 	.has_4tile = true,
+	.has_flatccs = true,
 	.is_lunarlake = true,
 	.codename = "lunarlake",
 	.cmds_info = &xe2_cmds_info,
Reviewed-by: Akshata Jahagirdar <akshata.jahagirdar@intel.com> 

    

  


--------------PaVYZhUcmGkO3hBJipRlFRll--