From: "Sharma, Swati2" <swati2.sharma@intel.com>
To: Sowmiya S <sowmiya.s@intel.com>, <igt-dev@lists.freedesktop.org>
Cc: <karthik.b.s@intel.com>
Subject: Re: [PATCH i-g-t v2] tests/intel/kms_frontbuffer_tracking: Improve skip message
Date: Thu, 9 Apr 2026 11:36:23 +0530 [thread overview]
Message-ID: <949079fd-cdaf-4c97-96bc-c35473fbc660@intel.com> (raw)
In-Reply-To: <20260409052614.1036375-1-sowmiya.s@intel.com>
Hi Sowmiya,
On 09-04-2026 10:56 am, Sowmiya S wrote:
> Improve skip message when igt can't find two
> outputs.
Commit message is lit bit vague.
Otherwise patch LGTM.
Reviewed-by: Swati Sharma <swati2.sharma@intel.com>
>
> Signed-off-by: Sowmiya S <sowmiya.s@intel.com>
> ---
> tests/intel/kms_frontbuffer_tracking.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/kms_frontbuffer_tracking.c b/tests/intel/kms_frontbuffer_tracking.c
> index c16f63199..8b73e8505 100644
> --- a/tests/intel/kms_frontbuffer_tracking.c
> +++ b/tests/intel/kms_frontbuffer_tracking.c
> @@ -2548,7 +2548,7 @@ static void check_test_requirements(const struct test_mode *t)
> {
> if (t->pipes == PIPE_DUAL)
> igt_require_f(scnd_mode_params.output,
> - "Can't test dual pipes with the current outputs\n");
> + "no valid secondary output available for dual-pipe tests\n");
>
> if (t->feature & FEATURE_FBC)
> igt_require_f(fbc.can_test,
prev parent reply other threads:[~2026-04-09 6:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-09 5:26 [PATCH i-g-t v2] tests/intel/kms_frontbuffer_tracking: Improve skip message Sowmiya S
2026-04-09 6:06 ` Sharma, Swati2 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=949079fd-cdaf-4c97-96bc-c35473fbc660@intel.com \
--to=swati2.sharma@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=karthik.b.s@intel.com \
--cc=sowmiya.s@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox