From: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
To: Kamil Konieczny <kamil.konieczny@linux.intel.com>,
igt-dev@lists.freedesktop.org, anonymoustranquillity@proton.me
Subject: Re: [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering
Date: Tue, 16 Jan 2024 08:49:50 +0000 [thread overview]
Message-ID: <960382c0-a8ef-464b-ada5-c9d66a58561e@linux.intel.com> (raw)
In-Reply-To: <20240115152907.ilhrhy5zhegt4b7l@kamilkon-desk.igk.intel.com>
Hi,
On 15/01/2024 15:29, Kamil Konieczny wrote:
> Hi anonymoustranquillity,
> On 2024-01-14 at 21:26:36 +0000, anonymoustranquillity@proton.me wrote:
>> Hello,
>>
>> there seems to be a problem with rendering in the interactive
>> mode in intel_gpu_top, seems to be a simple off-by-one. Below
>> is a patch. I am new to contributing via email, so I apologize
>> if I did something wrong - I tried to follow CONTRIBUTING.md
>> to the best of my ability.
What renders incorrectly? Asking since locally things look fine for me.
Regards,
Tvrtko
>>
>> Have a nice day,
>> - Ity.
>
> Thank you for patch, if you would like to use git and re-send
> with the help of 'git format-patch -1' and then
> 'git send e-mail 0001-your-first.patch'
>
> Before that setup your real name and e-mail in git configuration,
> like "First Last <your@email-address.me>"
>
> If it is too much bother someone can take it from here
> but without your real name we cannot give you contribution
> (except for link into patchwork).
>
> +cc Tvrtko
>
> Regards,
> Kamil
>
>>
>> ---
>> tools/intel_gpu_top.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
>> index 046ead15a..24363e72f 100644
>> --- a/tools/intel_gpu_top.c
>> +++ b/tools/intel_gpu_top.c
>> @@ -2178,7 +2178,7 @@ print_client(struct igt_drm_client *c, struct engines *engines, double t, int li
>> len += *class_w;
>> }
>>
>> - printf(" %-*s\n", con_w - len - 1, c->print_name);
>> + printf(" %-*s\n", con_w - len - 2, c->print_name);
>> } else if (output_mode == JSON) {
>> char buf[64];
>>
>> --
>> 2.43.0
>>
next prev parent reply other threads:[~2024-01-16 8:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 21:26 [PATCH i-g-t] tools/intel_gpu_top: Fix misaligned rendering anonymoustranquillity
2024-01-15 12:19 ` ✓ CI.xeBAT: success for " Patchwork
2024-01-15 12:39 ` ✗ Fi.CI.BAT: failure " Patchwork
2024-01-15 15:29 ` [PATCH i-g-t] " Kamil Konieczny
2024-01-16 8:49 ` Tvrtko Ursulin [this message]
[not found] ` <EOyBwdNxkVNQWyfdtYOrT4lVOSHddYw7GcBAVb3X7zd7i4PXIZfA2qPVZmOW89smu3o4u4cXUs5I6ebB2SxI-cC9JuCwyrsEBLPv9tjRRLk=@proton.me>
2024-01-16 9:42 ` Fw: " anonymoustranquillity
[not found] ` <02ed8aa7-f4e3-4648-b393-81cf103112e3@linux.intel.com>
2024-01-16 12:32 ` anonymoustranquillity
2024-01-16 13:03 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=960382c0-a8ef-464b-ada5-c9d66a58561e@linux.intel.com \
--to=tvrtko.ursulin@linux.intel.com \
--cc=anonymoustranquillity@proton.me \
--cc=igt-dev@lists.freedesktop.org \
--cc=kamil.konieczny@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox